* [PATCH] bridge: Fix compilation warning in function br_stp_recalculate_bridge_id()
@ 2011-03-29 16:20 G.Balaji
2011-03-29 18:10 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: G.Balaji @ 2011-03-29 16:20 UTC (permalink / raw)
To: shemminger; +Cc: bridge, netdev, G.Balaji
net/bridge/br_stp_if.c: In function ‘br_stp_recalculate_bridge_id’:
net/bridge/br_stp_if.c:216:3: warning: ‘return’ with no value, in function returning non-void
Signed-off-by: G.Balaji <balajig81@gmail.com>
---
net/bridge/br_stp_if.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c
index 5593f5a..9b61d09 100644
--- a/net/bridge/br_stp_if.c
+++ b/net/bridge/br_stp_if.c
@@ -213,7 +213,7 @@ bool br_stp_recalculate_bridge_id(struct net_bridge *br)
/* user has chosen a value so keep it */
if (br->flags & BR_SET_MAC_ADDR)
- return;
+ return false;
list_for_each_entry(p, &br->port_list, list) {
if (addr == br_mac_zero ||
--
1.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] bridge: Fix compilation warning in function br_stp_recalculate_bridge_id()
2011-03-29 16:20 [PATCH] bridge: Fix compilation warning in function br_stp_recalculate_bridge_id() G.Balaji
@ 2011-03-29 18:10 ` Stephen Hemminger
2011-03-30 6:37 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2011-03-29 18:10 UTC (permalink / raw)
To: G.Balaji; +Cc: shemminger, bridge, netdev
On Tue, 29 Mar 2011 21:50:04 +0530
"G.Balaji" <balajig81@gmail.com> wrote:
> net/bridge/br_stp_if.c: In function ‘br_stp_recalculate_bridge_id’:
> net/bridge/br_stp_if.c:216:3: warning: ‘return’ with no value, in function returning non-void
>
> Signed-off-by: G.Balaji <balajig81@gmail.com>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
(Forget to refresh quilt patch before sending).
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bridge: Fix compilation warning in function br_stp_recalculate_bridge_id()
2011-03-29 18:10 ` Stephen Hemminger
@ 2011-03-30 6:37 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2011-03-30 6:37 UTC (permalink / raw)
To: shemminger; +Cc: balajig81, shemminger, bridge, netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 29 Mar 2011 11:10:38 -0700
> On Tue, 29 Mar 2011 21:50:04 +0530
> "G.Balaji" <balajig81@gmail.com> wrote:
>
>> net/bridge/br_stp_if.c: In function ‘br_stp_recalculate_bridge_id’:
>> net/bridge/br_stp_if.c:216:3: warning: ‘return’ with no value, in function returning non-void
>>
>> Signed-off-by: G.Balaji <balajig81@gmail.com>
>
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>
>
> (Forget to refresh quilt patch before sending).
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-30 6:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-29 16:20 [PATCH] bridge: Fix compilation warning in function br_stp_recalculate_bridge_id() G.Balaji
2011-03-29 18:10 ` Stephen Hemminger
2011-03-30 6:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox