* [PATCH 38/42] netfilter: nf_conntrack_standalone: Fix set-but-unused variables.
@ 2011-04-18 0:34 David Miller
0 siblings, 0 replies; only message in thread
From: David Miller @ 2011-04-18 0:34 UTC (permalink / raw)
To: netdev
The variable 'ret' is set but unused in ct_seq_show().
This was obviously meant to be used to propagate error codes
to the caller, so make it so.
Signed-off-by: David S. Miller <davem@davemloft.net>
---
net/netfilter/nf_conntrack_standalone.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/netfilter/nf_conntrack_standalone.c b/net/netfilter/nf_conntrack_standalone.c
index 0ae1428..05e9feb 100644
--- a/net/netfilter/nf_conntrack_standalone.c
+++ b/net/netfilter/nf_conntrack_standalone.c
@@ -245,7 +245,7 @@ static int ct_seq_show(struct seq_file *s, void *v)
ret = 0;
release:
nf_ct_put(ct);
- return 0;
+ return ret;
}
static const struct seq_operations ct_seq_ops = {
--
1.7.4.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-04-18 0:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-18 0:34 [PATCH 38/42] netfilter: nf_conntrack_standalone: Fix set-but-unused variables David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox