Netdev List
 help / color / mirror / Atom feed
* [PATCH 40/42] netfilter: ip6table_mangle: Fix set-but-unused variables.
@ 2011-04-18  0:34 David Miller
  0 siblings, 0 replies; only message in thread
From: David Miller @ 2011-04-18  0:34 UTC (permalink / raw)
  To: netdev


The variable 'flowlabel' is set but unused in ip6t_mangle_out().

The intention here was to compare this key to the header value after
mangling, and trigger a route lookup on mismatch.

Make it so.

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 net/ipv6/netfilter/ip6table_mangle.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/net/ipv6/netfilter/ip6table_mangle.c b/net/ipv6/netfilter/ip6table_mangle.c
index 679a0a3..00d1917 100644
--- a/net/ipv6/netfilter/ip6table_mangle.c
+++ b/net/ipv6/netfilter/ip6table_mangle.c
@@ -64,7 +64,8 @@ ip6t_mangle_out(struct sk_buff *skb, const struct net_device *out)
 	    (memcmp(&ipv6_hdr(skb)->saddr, &saddr, sizeof(saddr)) ||
 	     memcmp(&ipv6_hdr(skb)->daddr, &daddr, sizeof(daddr)) ||
 	     skb->mark != mark ||
-	     ipv6_hdr(skb)->hop_limit != hop_limit))
+	     ipv6_hdr(skb)->hop_limit != hop_limit ||
+	     flowlabel != *((u_int32_t *)ipv6_hdr(skb))))
 		return ip6_route_me_harder(skb) == 0 ? ret : NF_DROP;
 
 	return ret;
-- 
1.7.4.3


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2011-04-18  0:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-18  0:34 [PATCH 40/42] netfilter: ip6table_mangle: Fix set-but-unused variables David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox