* [patch] netpoll: call dev_put() on error in netpoll_setup()
@ 2011-06-11 15:50 Dan Carpenter
2011-06-12 1:55 ` David Miller
2011-06-12 5:48 ` Américo Wang
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2011-06-11 15:50 UTC (permalink / raw)
To: WANG Cong
Cc: Herbert Xu, Neil Horman, David S. Miller, Eric Dumazet,
open list:NETWORKING [GENERAL], kernel-janitors
There is a dev_put(ndev) missing on an error path. This was
introduced in 0c1ad04aecb "netpoll: prevent netpoll setup on slave
devices".
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
This is a static checker bug, and it's possible I've misunderstood
something.
diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index 42ea4b0..18d9cbd 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -795,7 +795,8 @@ int netpoll_setup(struct netpoll *np)
if (ndev->master) {
printk(KERN_ERR "%s: %s is a slave device, aborting.\n",
np->name, np->dev_name);
- return -EBUSY;
+ err = -EBUSY;
+ goto put;
}
if (!netif_running(ndev)) {
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] netpoll: call dev_put() on error in netpoll_setup()
2011-06-11 15:50 [patch] netpoll: call dev_put() on error in netpoll_setup() Dan Carpenter
@ 2011-06-12 1:55 ` David Miller
2011-06-12 5:48 ` Américo Wang
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2011-06-12 1:55 UTC (permalink / raw)
To: error27; +Cc: amwang, herbert, nhorman, eric.dumazet, netdev, kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Sat, 11 Jun 2011 18:50:47 +0300
> There is a dev_put(ndev) missing on an error path. This was
> introduced in 0c1ad04aecb "netpoll: prevent netpoll setup on slave
> devices".
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> This is a static checker bug, and it's possible I've misunderstood
> something.
Definitely looks correct to me, applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] netpoll: call dev_put() on error in netpoll_setup()
2011-06-11 15:50 [patch] netpoll: call dev_put() on error in netpoll_setup() Dan Carpenter
2011-06-12 1:55 ` David Miller
@ 2011-06-12 5:48 ` Américo Wang
1 sibling, 0 replies; 3+ messages in thread
From: Américo Wang @ 2011-06-12 5:48 UTC (permalink / raw)
To: Dan Carpenter
Cc: WANG Cong, Herbert Xu, Neil Horman, David S. Miller, Eric Dumazet,
open list:NETWORKING [GENERAL], kernel-janitors
On Sat, Jun 11, 2011 at 11:50 PM, Dan Carpenter <error27@gmail.com> wrote:
> There is a dev_put(ndev) missing on an error path. This was
> introduced in 0c1ad04aecb "netpoll: prevent netpoll setup on slave
> devices".
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> This is a static checker bug, and it's possible I've misunderstood
> something.
Oops! My bad... you don't miss anything.
Thanks a lot for fixing it!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-12 5:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-11 15:50 [patch] netpoll: call dev_put() on error in netpoll_setup() Dan Carpenter
2011-06-12 1:55 ` David Miller
2011-06-12 5:48 ` Américo Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox