* [PATCH] myri10ge: 64bit slice stats
@ 2011-06-20 18:46 Jon Mason
2011-06-20 18:49 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Jon Mason @ 2011-06-20 18:46 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Andrew Gallatin, Eric Dumazet
There is a potential issue of internal 32bit stats wrapping before
updating the external 64bit stats, thus leading to incorrect stats.
Since there is no hardware necessity for these counters to be 32bit,
change them to be 64bit to avoid this issue.
Patch suggested by Eric Dumazet.
Signed-off-by: Jon Mason <mason@myri.com>
---
drivers/net/myri10ge/myri10ge.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
index 04e10f4..2a51de1 100644
--- a/drivers/net/myri10ge/myri10ge.c
+++ b/drivers/net/myri10ge/myri10ge.c
@@ -170,12 +170,12 @@ struct myri10ge_rx_done {
};
struct myri10ge_slice_netstats {
- unsigned long rx_packets;
- unsigned long tx_packets;
- unsigned long rx_bytes;
- unsigned long tx_bytes;
- unsigned long rx_dropped;
- unsigned long tx_dropped;
+ u64 rx_packets;
+ u64 tx_packets;
+ u64 rx_bytes;
+ u64 tx_bytes;
+ u64 rx_dropped;
+ u64 tx_dropped;
};
struct myri10ge_slice_state {
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] myri10ge: 64bit slice stats
2011-06-20 18:46 [PATCH] myri10ge: 64bit slice stats Jon Mason
@ 2011-06-20 18:49 ` Eric Dumazet
2011-06-20 18:52 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2011-06-20 18:49 UTC (permalink / raw)
To: Jon Mason; +Cc: David Miller, netdev, Andrew Gallatin
Le lundi 20 juin 2011 à 13:46 -0500, Jon Mason a écrit :
> There is a potential issue of internal 32bit stats wrapping before
> updating the external 64bit stats, thus leading to incorrect stats.
> Since there is no hardware necessity for these counters to be 32bit,
> change them to be 64bit to avoid this issue.
>
> Patch suggested by Eric Dumazet.
>
> Signed-off-by: Jon Mason <mason@myri.com>
> ---
> drivers/net/myri10ge/myri10ge.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
> index 04e10f4..2a51de1 100644
> --- a/drivers/net/myri10ge/myri10ge.c
> +++ b/drivers/net/myri10ge/myri10ge.c
> @@ -170,12 +170,12 @@ struct myri10ge_rx_done {
> };
>
> struct myri10ge_slice_netstats {
> - unsigned long rx_packets;
> - unsigned long tx_packets;
> - unsigned long rx_bytes;
> - unsigned long tx_bytes;
> - unsigned long rx_dropped;
> - unsigned long tx_dropped;
> + u64 rx_packets;
> + u64 tx_packets;
> + u64 rx_bytes;
> + u64 tx_bytes;
> + u64 rx_dropped;
> + u64 tx_dropped;
> };
>
> struct myri10ge_slice_state {
Hmm, no sorry, this wont work on 32bit arches :(
Please take a look at various patches addressing this problem.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-20 18:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-20 18:46 [PATCH] myri10ge: 64bit slice stats Jon Mason
2011-06-20 18:49 ` Eric Dumazet
2011-06-20 18:52 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox