From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Sedat Cakir <cakir_sedat@yahoo.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: GRO support in the bridge
Date: Wed, 10 Aug 2011 08:08:31 -0700 [thread overview]
Message-ID: <20110810080831.05de9a5f@nehalam.ftrdhcpuser.net> (raw)
In-Reply-To: <1312979355.53304.YahooMailNeo@web110404.mail.gq1.yahoo.com>
On Wed, 10 Aug 2011 05:29:15 -0700 (PDT)
Sedat Cakir <cakir_sedat@yahoo.com> wrote:
> Hi,
>
>
>
> I am trying to understand why GRO is NOT enabled on the bridge. Is there a special reason for it? Reading the code in net/core/dev.c:2817 (__netif_receieve_skb) which is what I think the bridge is calling because that is what is passed in at br_input.c:br_pass_frame_up():24. I am wondering if this can be modified to use one of the _gro_ receive functions and if so if that will positively impact performance? Do you have any idea?
>
> Appreciate your help.Thanks,
> Sedat
The reason is that GRO is related to NAPI.
GRO works by coalescing frames received in one NAPI interval
of work. The bridge itself has no receive irq or NAPI and is upcalled
from the device receive handler. There is no expectation or
requirement that devices in a bridge use NAPI. Therefore it
is not possible or safe for bridge pseudo-device to use GRO.
parent reply other threads:[~2011-08-10 15:08 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1312979355.53304.YahooMailNeo@web110404.mail.gq1.yahoo.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110810080831.05de9a5f@nehalam.ftrdhcpuser.net \
--to=shemminger@linux-foundation.org \
--cc=cakir_sedat@yahoo.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox