* Re: GRO support in the bridge
[not found] ` <1312979355.53304.YahooMailNeo@web110404.mail.gq1.yahoo.com>
@ 2011-08-10 15:08 ` Stephen Hemminger
0 siblings, 0 replies; only message in thread
From: Stephen Hemminger @ 2011-08-10 15:08 UTC (permalink / raw)
To: Sedat Cakir; +Cc: netdev@vger.kernel.org
On Wed, 10 Aug 2011 05:29:15 -0700 (PDT)
Sedat Cakir <cakir_sedat@yahoo.com> wrote:
> Hi,
>
>
>
> I am trying to understand why GRO is NOT enabled on the bridge. Is there a special reason for it? Reading the code in net/core/dev.c:2817 (__netif_receieve_skb) which is what I think the bridge is calling because that is what is passed in at br_input.c:br_pass_frame_up():24. I am wondering if this can be modified to use one of the _gro_ receive functions and if so if that will positively impact performance? Do you have any idea?
>
> Appreciate your help.Thanks,
> Sedat
The reason is that GRO is related to NAPI.
GRO works by coalescing frames received in one NAPI interval
of work. The bridge itself has no receive irq or NAPI and is upcalled
from the device receive handler. There is no expectation or
requirement that devices in a bridge use NAPI. Therefore it
is not possible or safe for bridge pseudo-device to use GRO.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-08-10 15:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1312884184.2170.YahooMailNeo@web110401.mail.gq1.yahoo.com>
[not found] ` <1312958391.84140.YahooMailNeo@web110415.mail.gq1.yahoo.com>
[not found] ` <1312979355.53304.YahooMailNeo@web110404.mail.gq1.yahoo.com>
2011-08-10 15:08 ` GRO support in the bridge Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox