* IFF_TX_SKB_SHARING
@ 2011-09-14 10:38 Pekka Riikonen
2011-09-14 11:09 ` IFF_TX_SKB_SHARING Neil Horman
2011-09-14 11:46 ` IFF_TX_SKB_SHARING Eric Dumazet
0 siblings, 2 replies; 3+ messages in thread
From: Pekka Riikonen @ 2011-09-14 10:38 UTC (permalink / raw)
To: netdev; +Cc: nhorman
The IFF_TX_SKB_SHARING flag was introduced in d88733150. Was it intended
that it clears IFF_XMIT_DST_RELEASE flag? It's set in alloc_netdev_mqs
but gets cleared by ether_setup (via alloc_etherdev_mqs).
Thanks,
Pekka
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: IFF_TX_SKB_SHARING
2011-09-14 10:38 IFF_TX_SKB_SHARING Pekka Riikonen
@ 2011-09-14 11:09 ` Neil Horman
2011-09-14 11:46 ` IFF_TX_SKB_SHARING Eric Dumazet
1 sibling, 0 replies; 3+ messages in thread
From: Neil Horman @ 2011-09-14 11:09 UTC (permalink / raw)
To: Pekka Riikonen; +Cc: netdev
On Wed, Sep 14, 2011 at 12:38:42PM +0200, Pekka Riikonen wrote:
>
> The IFF_TX_SKB_SHARING flag was introduced in d88733150. Was it
> intended that it clears IFF_XMIT_DST_RELEASE flag? It's set in
> alloc_netdev_mqs but gets cleared by ether_setup (via
> alloc_etherdev_mqs).
>
> Thanks,
>
> Pekka
>
No, thats in error, the sharing flag was meant to be or-ed in. I'll fix that
immediately, thanks!
Neil
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: IFF_TX_SKB_SHARING
2011-09-14 10:38 IFF_TX_SKB_SHARING Pekka Riikonen
2011-09-14 11:09 ` IFF_TX_SKB_SHARING Neil Horman
@ 2011-09-14 11:46 ` Eric Dumazet
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2011-09-14 11:46 UTC (permalink / raw)
To: Pekka Riikonen; +Cc: netdev, nhorman
Le mercredi 14 septembre 2011 à 12:38 +0200, Pekka Riikonen a écrit :
> The IFF_TX_SKB_SHARING flag was introduced in d88733150. Was it intended
> that it clears IFF_XMIT_DST_RELEASE flag? It's set in alloc_netdev_mqs
> but gets cleared by ether_setup (via alloc_etherdev_mqs).
>
Good catch, thanks Pekka
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-14 11:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-14 10:38 IFF_TX_SKB_SHARING Pekka Riikonen
2011-09-14 11:09 ` IFF_TX_SKB_SHARING Neil Horman
2011-09-14 11:46 ` IFF_TX_SKB_SHARING Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox