* re: bna: PCI Probe Fix
@ 2011-09-20 8:47 Dan Carpenter
2011-09-22 0:32 ` Rasesh Mody
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-09-20 8:47 UTC (permalink / raw)
To: Rasesh Mody; +Cc: netdev
Hi Rasesh,
There is a problem introduced in 0caa9aaec5 "bna: PCI Probe Fix".
If register_netdev() fails now, then we call mutex_unlock(&bnad->conf_mutex);
on the error path, but it's already unlocked.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: bna: PCI Probe Fix
2011-09-20 8:47 bna: PCI Probe Fix Dan Carpenter
@ 2011-09-22 0:32 ` Rasesh Mody
0 siblings, 0 replies; 2+ messages in thread
From: Rasesh Mody @ 2011-09-22 0:32 UTC (permalink / raw)
To: Dan Carpenter; +Cc: netdev@vger.kernel.org
>From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
>Sent: Tuesday, September 20, 2011 1:47 AM
>
>There is a problem introduced in 0caa9aaec5 "bna: PCI Probe Fix".
>
>If register_netdev() fails now, then we call mutex_unlock(&bnad-
>>conf_mutex);
>on the error path, but it's already unlocked.
Thanks Dan!
Sent a fix so that we acquire the lock in error path which will be later unlocked after the cleanup.
Regards,
Rasesh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-22 0:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-20 8:47 bna: PCI Probe Fix Dan Carpenter
2011-09-22 0:32 ` Rasesh Mody
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox