* [PATCH] rds: drop "select LLIST"
@ 2011-11-13 13:36 Paul Bolle
2011-11-14 5:12 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Paul Bolle @ 2011-11-13 13:36 UTC (permalink / raw)
To: Venkat Venkatsubra, David S. Miller; +Cc: rds-devel, netdev, linux-kernel
Commit 1bc144b625 ("net, rds, Replace xlist in net/rds/xlist.h with
llist") added "select LLIST" to the RDS_RDMA Kconfig entry. But there is
no Kconfig symbol named LLIST. The select statement for that symbol is a
nop. Drop it.
lib/llist.o is builtin, so all that's needed to use the llist
functionality is to include linux/llist.h, which this commit also did.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Tested with "yes "" | make config" before and after applying this patch.
Identical .config files were generated, as was expected
net/rds/Kconfig | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/net/rds/Kconfig b/net/rds/Kconfig
index 4cf6dc7..ec753b3 100644
--- a/net/rds/Kconfig
+++ b/net/rds/Kconfig
@@ -9,7 +9,6 @@ config RDS
config RDS_RDMA
tristate "RDS over Infiniband and iWARP"
- select LLIST
depends on RDS && INFINIBAND && INFINIBAND_ADDR_TRANS
---help---
Allow RDS to use Infiniband and iWARP as a transport.
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] rds: drop "select LLIST"
2011-11-13 13:36 [PATCH] rds: drop "select LLIST" Paul Bolle
@ 2011-11-14 5:12 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-11-14 5:12 UTC (permalink / raw)
To: pebolle; +Cc: venkat.x.venkatsubra, rds-devel, netdev, linux-kernel
From: Paul Bolle <pebolle@tiscali.nl>
Date: Sun, 13 Nov 2011 14:36:37 +0100
> Commit 1bc144b625 ("net, rds, Replace xlist in net/rds/xlist.h with
> llist") added "select LLIST" to the RDS_RDMA Kconfig entry. But there is
> no Kconfig symbol named LLIST. The select statement for that symbol is a
> nop. Drop it.
>
> lib/llist.o is builtin, so all that's needed to use the llist
> functionality is to include linux/llist.h, which this commit also did.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-14 5:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-13 13:36 [PATCH] rds: drop "select LLIST" Paul Bolle
2011-11-14 5:12 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox