From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: rick.jones2@hp.com, tparkin@katalix.com, netdev@vger.kernel.org,
David.Laight@ACULAB.COM, jchapman@katalix.com
Subject: Re: [PATCH v2] l2tp: use per-cpu variables for u64_stats updates
Date: Wed, 27 Jun 2012 15:21:53 -0700 (PDT) [thread overview]
Message-ID: <20120627.152153.75362722222316911.davem@davemloft.net> (raw)
In-Reply-To: <1340829541.26242.90.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 27 Jun 2012 22:39:01 +0200
> In 2012 or 2013, 64bits kernels are the norm, and 32bit the exception.
>
> Should we add complex code to l2tp just for being able to run it on
> 32bit kernels with 64bit stats ?
>
> Considering this code is buggy at the v1 & v2, I am really wondering.
>
> All sane SNMP applications are ready to cope with 32bits counters
> wrapping.
>
> Machines that could wrap the 32bit counter several times per second are
> probably running on 64bit kernels.
>
> Also percpu stats are overkill unless a device is really meant to be
> used in // by many cpus.
I agree with Eric on all counts.
prev parent reply other threads:[~2012-06-27 22:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 12:00 [PATCH v2] l2tp: use per-cpu variables for u64_stats updates Tom Parkin
2012-06-27 19:03 ` Eric Dumazet
2012-06-27 20:21 ` Rick Jones
2012-06-27 20:39 ` Eric Dumazet
2012-06-27 20:50 ` Stephen Hemminger
2012-06-27 20:58 ` Ben Greear
2012-06-27 21:20 ` Eric Dumazet
2012-06-27 21:31 ` Ben Greear
2012-06-27 21:35 ` Eric Dumazet
2012-06-27 23:01 ` Rick Jones
2012-06-27 23:09 ` David Miller
2012-06-27 23:39 ` Rick Jones
2012-06-28 5:00 ` Eric Dumazet
2012-06-28 8:24 ` Tom Parkin
2012-06-28 8:46 ` David Laight
2012-06-28 18:17 ` Ben Hutchings
2012-06-27 21:32 ` Eric Dumazet
2012-06-27 21:40 ` Ben Greear
2012-06-27 21:50 ` Eric Dumazet
2012-06-27 21:00 ` Rick Jones
2012-06-27 22:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120627.152153.75362722222316911.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=David.Laight@ACULAB.COM \
--cc=eric.dumazet@gmail.com \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
--cc=tparkin@katalix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox