* [patch] net/mlx4_en: dereferencing freed memory
@ 2012-07-11 6:34 Dan Carpenter
2012-07-17 5:58 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-07-11 6:34 UTC (permalink / raw)
To: Yevgeny Petrilin
Cc: David S. Miller, Amir Vadai, Or Gerlitz, Alexander Guller, netdev,
kernel-janitors
We dereferenced "mclist" after the kfree().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index 94375a8..4ce5ca8 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -503,9 +503,7 @@ static void mlx4_en_do_set_multicast(struct work_struct *work)
/* remove from list */
list_del(&mclist->list);
kfree(mclist);
- }
-
- if (mclist->action == MCLIST_ADD) {
+ } else if (mclist->action == MCLIST_ADD) {
/* attach the address */
memcpy(&mc_list[10], mclist->addr, ETH_ALEN);
/* needed for B0 steering support */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] net/mlx4_en: dereferencing freed memory
2012-07-11 6:34 [patch] net/mlx4_en: dereferencing freed memory Dan Carpenter
@ 2012-07-17 5:58 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-07-17 5:58 UTC (permalink / raw)
To: dan.carpenter; +Cc: yevgenyp, amirv, ogerlitz, alexg, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 11 Jul 2012 09:34:07 +0300
> We dereferenced "mclist" after the kfree().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-17 5:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-11 6:34 [patch] net/mlx4_en: dereferencing freed memory Dan Carpenter
2012-07-17 5:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox