From: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
To: netdev@vger.kernel.org
Cc: Steve Glendinning <steve.glendinning@shawell.net>
Subject: smsc75xx & smsc95xx, setting skb->truesize correctly?
Date: Mon, 20 Aug 2012 17:57:06 +0300 [thread overview]
Message-ID: <20120820175706.12394vktsvm3yvqc@www.81.fi> (raw)
Hello,
Is setting skb->truesize in smsc75xx and smsc95xx correct?
In smsc75xx/smsc95xx_rx_fixup(), input skb containing multiple packets
is cloned and truesize for each clone is set to packet-size +
sizeof(struct sk_buff), but input skb has minimum allocation size of
9000 bytes (MAX_SINGLE_PACKET_SIZE) and maximum of 18944 bytes
(DEFAULT_HS_BURST_CAP_SIZE) (+ NET_IP_ALIGN). Doesn't this cause
truesize to be underestimated?
-Jussi
next reply other threads:[~2012-08-20 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 14:57 Jussi Kivilinna [this message]
2012-08-21 9:46 ` smsc75xx & smsc95xx, setting skb->truesize correctly? Eric Dumazet
2012-08-22 5:35 ` Jussi Kivilinna
2012-08-22 6:34 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120820175706.12394vktsvm3yvqc@www.81.fi \
--to=jussi.kivilinna@mbnet.fi \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox