From: David Miller <davem@davemloft.net>
To: ordex@autistici.org
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
sven@narfation.org, lindner_marek@yahoo.de
Subject: Re: [PATCH 9/9] batman-adv: Use packing of 2 for all headers before an ethernet header
Date: Wed, 21 Nov 2012 12:57:59 -0500 (EST) [thread overview]
Message-ID: <20121121.125759.322762083309845086.davem@davemloft.net> (raw)
In-Reply-To: <1353499919-28596-10-git-send-email-ordex@autistici.org>
From: Antonio Quartulli <ordex@autistici.org>
Date: Wed, 21 Nov 2012 13:11:59 +0100
> +#pragma pack(2)
...
> -} __packed;
The __packed attribute is an abstraction of the actual syntax
the compiler uses, if it is supported at all.
Therefore, you can't just unconditionally use the #pragma, and
you would need to use some kind of similar compiler abstraction
for it.
But to be honest this is really ugly and for very little, if any,
gain.
next prev parent reply other threads:[~2012-11-21 17:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 12:11 pull request: batman-adv 2012-11-21 Antonio Quartulli
2012-11-21 12:11 ` [PATCH 1/9] batman-adv: Mark best gateway in transtable_global debugfs Antonio Quartulli
2012-11-21 12:11 ` [PATCH 2/9] batman-adv: fix bla compare function Antonio Quartulli
2012-11-21 12:11 ` [PATCH 3/9] batman-adv: support array of debugfs general attributes Antonio Quartulli
2012-11-21 12:11 ` [PATCH 4/9] batman-adv: Add wrapper to look up neighbor and send skb Antonio Quartulli
2012-11-21 12:11 ` [PATCH 5/9] batman-adv: sysfs documentation should keep alphabetical order Antonio Quartulli
2012-11-21 12:11 ` [PATCH 6/9] batman-adv: Add function to calculate crc32c for the skb payload Antonio Quartulli
2012-11-21 12:11 ` [PATCH 7/9] batman-adv: Fix broadcast duplist for fragmentation Antonio Quartulli
2012-11-21 12:11 ` [PATCH 8/9] batman-adv: Start new development cycle Antonio Quartulli
2012-11-21 12:11 ` [PATCH 9/9] batman-adv: Use packing of 2 for all headers before an ethernet header Antonio Quartulli
2012-11-21 13:36 ` David Laight
[not found] ` <AE90C24D6B3A694183C094C60CF0A2F6026B70BB-CgBM+Bx2aUAnGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2012-11-21 13:51 ` Sven Eckelmann
2012-11-21 17:57 ` David Miller [this message]
2012-11-21 18:20 ` Sven Eckelmann
2012-11-21 20:31 ` David Miller
[not found] ` <8108710.8oNxxR0rRd-S/pmIDWWJIwhrEaHGRlFQnOel7F/LzPIcbWoRP8EXgk@public.gmane.org>
2012-11-22 8:12 ` Kevin Curtis
[not found] ` <E603DC592C92B54A89CEF6B0919A0B1CA7D5A6CC87-uLMF5YoEu3cpvdBnIIuIUrTzKHr1x449ALKb+EK9MtIAvxtiuMwx3w@public.gmane.org>
2012-11-22 8:28 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121.125759.322762083309845086.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=lindner_marek@yahoo.de \
--cc=netdev@vger.kernel.org \
--cc=ordex@autistici.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox