From: Sven Eckelmann <sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org>
To: Kevin Curtis <Kevin.Curtis-AP8L3A0T/wRBDgjK7y7TUQ@public.gmane.org>
Cc: "fubar-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org"
<fubar-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
"netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org"
<b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org>,
"jitendra.kalsaria-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org"
<jitendra.kalsaria-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org>,
"rmody-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org"
<rmody-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>,
"ron.mercer-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org"
<ron.mercer-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org>,
"linux-driver-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org"
<linux-driver-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org>,
"lindner_marek-LWAfsSFWpa4@public.gmane.org"
<lindner_marek-LWAfsSFWpa4@public.gmane.org>,
David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
"andy-QlMahl40kYEqcZcGjlUOXw@public.gmane.org"
<andy-QlMahl40kYEqcZcGjlUOXw@public.gmane.org>
Subject: Re: [PATCH 9/9] batman-adv: Use packing of 2 for all headers before an ethernet header
Date: Thu, 22 Nov 2012 09:28:36 +0100 [thread overview]
Message-ID: <3602626.rWyvU1cq5r@bentobox> (raw)
In-Reply-To: <E603DC592C92B54A89CEF6B0919A0B1CA7D5A6CC87-uLMF5YoEu3cpvdBnIIuIUrTzKHr1x449ALKb+EK9MtIAvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
On Thursday 22 November 2012 08:12:38 Kevin Curtis wrote:
> >> Agree. But we should get this message also to the other guys
>
> What message would this be?
> Are you advocating a different use of #pragma pack()?
David started this discussion and his statement was:
> The __packed attribute is an abstraction of the actual syntax the
> compiler uses, if it is supported at all.
>
> Therefore, you can't just unconditionally use the #pragma, and you
> would need to use some kind of similar compiler abstraction for it.
So yes, it sounds to me like "don't use #pragma but think about some
abstraction".
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-11-22 8:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 12:11 pull request: batman-adv 2012-11-21 Antonio Quartulli
2012-11-21 12:11 ` [PATCH 1/9] batman-adv: Mark best gateway in transtable_global debugfs Antonio Quartulli
2012-11-21 12:11 ` [PATCH 2/9] batman-adv: fix bla compare function Antonio Quartulli
2012-11-21 12:11 ` [PATCH 3/9] batman-adv: support array of debugfs general attributes Antonio Quartulli
2012-11-21 12:11 ` [PATCH 4/9] batman-adv: Add wrapper to look up neighbor and send skb Antonio Quartulli
2012-11-21 12:11 ` [PATCH 5/9] batman-adv: sysfs documentation should keep alphabetical order Antonio Quartulli
2012-11-21 12:11 ` [PATCH 6/9] batman-adv: Add function to calculate crc32c for the skb payload Antonio Quartulli
2012-11-21 12:11 ` [PATCH 7/9] batman-adv: Fix broadcast duplist for fragmentation Antonio Quartulli
2012-11-21 12:11 ` [PATCH 8/9] batman-adv: Start new development cycle Antonio Quartulli
2012-11-21 12:11 ` [PATCH 9/9] batman-adv: Use packing of 2 for all headers before an ethernet header Antonio Quartulli
2012-11-21 13:36 ` David Laight
[not found] ` <AE90C24D6B3A694183C094C60CF0A2F6026B70BB-CgBM+Bx2aUAnGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2012-11-21 13:51 ` Sven Eckelmann
2012-11-21 17:57 ` David Miller
2012-11-21 18:20 ` Sven Eckelmann
2012-11-21 20:31 ` David Miller
[not found] ` <8108710.8oNxxR0rRd-S/pmIDWWJIwhrEaHGRlFQnOel7F/LzPIcbWoRP8EXgk@public.gmane.org>
2012-11-22 8:12 ` Kevin Curtis
[not found] ` <E603DC592C92B54A89CEF6B0919A0B1CA7D5A6CC87-uLMF5YoEu3cpvdBnIIuIUrTzKHr1x449ALKb+EK9MtIAvxtiuMwx3w@public.gmane.org>
2012-11-22 8:28 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3602626.rWyvU1cq5r@bentobox \
--to=sven-kadoipu9uxwei8dpzvb4nw@public.gmane.org \
--cc=Kevin.Curtis-AP8L3A0T/wRBDgjK7y7TUQ@public.gmane.org \
--cc=andy-QlMahl40kYEqcZcGjlUOXw@public.gmane.org \
--cc=b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=fubar-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=jitendra.kalsaria-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org \
--cc=lindner_marek-LWAfsSFWpa4@public.gmane.org \
--cc=linux-driver-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rmody-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org \
--cc=ron.mercer-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox