From: David Miller <davem@davemloft.net>
To: bjorn@mork.no
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
gsuarez@smithmicro.com, alexey.orishko@stericsson.com
Subject: Re: [PATCH net,stable-3.8] net: cdc_ncm, cdc_mbim: allow user to prefer NCM for backwards compatibility
Date: Sun, 17 Mar 2013 12:00:00 -0400 (EDT) [thread overview]
Message-ID: <20130317.120000.2052121747248366215.davem@davemloft.net> (raw)
In-Reply-To: <1363259113-6909-1-git-send-email-bjorn@mork.no>
From: Bjørn Mork <bjorn@mork.no>
Date: Thu, 14 Mar 2013 12:05:13 +0100
> commit bd329e1 ("net: cdc_ncm: do not bind to NCM compatible MBIM devices")
> introduced a new policy, preferring MBIM for dual NCM/MBIM functions if
> the cdc_mbim driver was enabled. This caused a regression for users
> wanting to use NCM.
>
> Devices implementing NCM backwards compatibility according to section
> 3.2 of the MBIM v1.0 specification allow either NCM or MBIM on a single
> USB function, using different altsettings. The cdc_ncm and cdc_mbim
> drivers will both probe such functions, and must agree on a common
> policy for selecting either MBIM or NCM. Until now, this policy has
> been set at build time based on CONFIG_USB_NET_CDC_MBIM.
>
> Use a module parameter to set the system policy at runtime, allowing the
> user to prefer NCM on systems with the cdc_mbim driver.
>
> Cc: Greg Suarez <gsuarez@smithmicro.com>
> Cc: Alexey Orishko <alexey.orishko@stericsson.com>
> Reported-by: Geir Haatveit <nospam@haatveit.nu>
> Reported-by: Tommi Kyntola <kynde@ts.ray.fi>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=54791
> Signed-off-by: Bjørn Mork <bjorn@mork.no>
Ok, this is fine as a solution for now, applied and queued up for -stable.
prev parent reply other threads:[~2013-03-17 16:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 11:05 [PATCH net,stable-3.8] net: cdc_ncm, cdc_mbim: allow user to prefer NCM for backwards compatibility Bjørn Mork
[not found] ` <1363259113-6909-1-git-send-email-bjorn-yOkvZcmFvRU@public.gmane.org>
2013-03-15 5:22 ` Ben Hutchings
2013-03-15 7:02 ` Bjørn Mork
2013-03-16 17:51 ` Ben Hutchings
2013-03-17 16:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130317.120000.2052121747248366215.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexey.orishko@stericsson.com \
--cc=bjorn@mork.no \
--cc=gsuarez@smithmicro.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox