From: David Miller <davem@davemloft.net>
To: maze@google.com
Cc: dkravkov@gmail.com, eric.dumazet@gmail.com,
netdev@vger.kernel.org, dmitry@broadcom.com, eilong@broadcom.com,
pshelar@nicira.com, hkchu@google.com
Subject: Re: [PATCH net-next] gro: relax ID check in inet_gro_receive()
Date: Thu, 21 Mar 2013 16:20:17 -0400 (EDT) [thread overview]
Message-ID: <20130321.162017.605403865098695084.davem@davemloft.net> (raw)
In-Reply-To: <CANP3RGc1+n3Qt7k53NJtPO9njZw+WNVLKTLJq=ErYJmyb-Skcg@mail.gmail.com>
From: Maciej Żenczykowski <maze@google.com>
Date: Thu, 21 Mar 2013 13:14:44 -0700
> Reverting/deleting this code is going way too far.
> Mark it experimental, but don't delete it.
I disagree, people who want to play can apply the code
to their tree.
It's as simple as that.
We have very reasonable requirements for segmentation offloads, if
they are not met, the feature isn't working correctly and therefore
isn't ready for upstream.
Now if someone can provide a fix soon, that's fine too.
next prev parent reply other threads:[~2013-03-21 20:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 4:52 [PATCH net-next] gro: relax ID check in inet_gro_receive() Eric Dumazet
2013-03-21 9:59 ` Maciej Żenczykowski
2013-03-21 10:05 ` Maciej Żenczykowski
2013-03-21 14:56 ` David Miller
2013-03-21 15:46 ` David Miller
2013-03-21 16:08 ` Eric Dumazet
2013-03-21 16:31 ` David Miller
2013-03-21 18:11 ` Dmitry Kravkov
2013-03-21 18:56 ` David Miller
2013-03-21 20:14 ` Maciej Żenczykowski
2013-03-21 20:20 ` David Miller [this message]
2013-03-21 20:47 ` Maciej Żenczykowski
2013-03-21 21:05 ` David Miller
2013-03-21 21:37 ` Jesse Gross
2013-03-21 21:39 ` David Miller
[not found] ` <CAM8tLiPh=g1+XqhwKQAH7XyTmpT80j5422VXGjLksxtFxYoxRQ@mail.gmail.com>
2013-03-21 20:07 ` Maciej Żenczykowski
2013-03-21 20:13 ` Dmitry Kravkov
2013-03-21 16:20 ` Ben Hutchings
2013-03-21 16:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321.162017.605403865098695084.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dkravkov@gmail.com \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=eric.dumazet@gmail.com \
--cc=hkchu@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox