* [PATCH] TTY: ircomm, use GFP_KERNEL in ircomm_open()
@ 2013-04-05 21:02 Mathias Krause
2013-04-05 21:15 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Mathias Krause @ 2013-04-05 21:02 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Samuel Ortiz, David S. Miller, netdev, Mathias Krause
Hi Greg,
I'm unsure if you or Dave should take that one as it's for one a TTY
patch but also living under net/. So I'm uncertain and let you decide!
Thanks,
Mathias
-- >8 --
Subject: [PATCH] TTY: ircomm, use GFP_KERNEL in ircomm_open()
We're clearly running in non-atomic context as our only call site is
able to call wait_event_interruptible(). So we're safe to use GFP_KERNEL
here instead of GFP_ATOMIC.
Signed-off-by: Mathias Krause <minipli@googlemail.com>
---
net/irda/ircomm/ircomm_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/irda/ircomm/ircomm_core.c b/net/irda/ircomm/ircomm_core.c
index 52079f1..b797daa 100644
--- a/net/irda/ircomm/ircomm_core.c
+++ b/net/irda/ircomm/ircomm_core.c
@@ -117,7 +117,7 @@ struct ircomm_cb *ircomm_open(notify_t *notify, __u8 service_type, int line)
IRDA_ASSERT(ircomm != NULL, return NULL;);
- self = kzalloc(sizeof(struct ircomm_cb), GFP_ATOMIC);
+ self = kzalloc(sizeof(struct ircomm_cb), GFP_KERNEL);
if (self == NULL)
return NULL;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] TTY: ircomm, use GFP_KERNEL in ircomm_open()
2013-04-05 21:02 [PATCH] TTY: ircomm, use GFP_KERNEL in ircomm_open() Mathias Krause
@ 2013-04-05 21:15 ` Greg Kroah-Hartman
2013-04-08 16:10 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2013-04-05 21:15 UTC (permalink / raw)
To: Mathias Krause; +Cc: Samuel Ortiz, David S. Miller, netdev
On Fri, Apr 05, 2013 at 11:02:07PM +0200, Mathias Krause wrote:
> Hi Greg,
>
> I'm unsure if you or Dave should take that one as it's for one a TTY
> patch but also living under net/. So I'm uncertain and let you decide!
If Dave want to take it, it's fine with me:
> -- >8 --
> Subject: [PATCH] TTY: ircomm, use GFP_KERNEL in ircomm_open()
>
> We're clearly running in non-atomic context as our only call site is
> able to call wait_event_interruptible(). So we're safe to use GFP_KERNEL
> here instead of GFP_ATOMIC.
>
> Signed-off-by: Mathias Krause <minipli@googlemail.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] TTY: ircomm, use GFP_KERNEL in ircomm_open()
2013-04-05 21:15 ` Greg Kroah-Hartman
@ 2013-04-08 16:10 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-04-08 16:10 UTC (permalink / raw)
To: gregkh; +Cc: minipli, samuel, netdev
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Fri, 5 Apr 2013 14:15:00 -0700
> On Fri, Apr 05, 2013 at 11:02:07PM +0200, Mathias Krause wrote:
>> Hi Greg,
>>
>> I'm unsure if you or Dave should take that one as it's for one a TTY
>> patch but also living under net/. So I'm uncertain and let you decide!
>
> If Dave want to take it, it's fine with me:
>
>> -- >8 --
>> Subject: [PATCH] TTY: ircomm, use GFP_KERNEL in ircomm_open()
>>
>> We're clearly running in non-atomic context as our only call site is
>> able to call wait_event_interruptible(). So we're safe to use GFP_KERNEL
>> here instead of GFP_ATOMIC.
>>
>> Signed-off-by: Mathias Krause <minipli@googlemail.com>
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-08 16:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-05 21:02 [PATCH] TTY: ircomm, use GFP_KERNEL in ircomm_open() Mathias Krause
2013-04-05 21:15 ` Greg Kroah-Hartman
2013-04-08 16:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox