Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, bhutchings@solarflare.com
Subject: Re: [PATCH v2 net-next] net_sched: add 64bit rate estimators
Date: Tue, 11 Jun 2013 02:51:32 -0700 (PDT)	[thread overview]
Message-ID: <20130611.025132.157790026336411319.davem@davemloft.net> (raw)
In-Reply-To: <1370533402.24311.353.camel@edumazet-glaptop>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 06 Jun 2013 08:43:22 -0700

> From: Eric Dumazet <edumazet@google.com>
> 
> struct gnet_stats_rate_est contains u32 fields, so the bytes per second
> field can wrap at 34360Mbit.
> 
> Add a new gnet_stats_rate_est64 structure to get 64bit bps/pps fields,
> and switch the kernel to use this structure natively.
> 
> This structure is dumped to user space as a new attribute :
> 
> TCA_STATS_RATE_EST64
> 
> Old tc command will now display the capped bps (to 34360Mbit), instead
> of wrapped values, and updated tc command will display correct
> information.
> 
> Old tc command output, after patch :
> 
> eric:~# tc -s -d qd sh dev lo
> qdisc pfifo 8001: root refcnt 2 limit 1000p
>  Sent 80868245400 bytes 1978837 pkt (dropped 0, overlimits 0 requeues 0) 
>  rate 34360Mbit 189696pps backlog 0b 0p requeues 0 
> 
> This patch carefully reorganizes "struct Qdisc" layout to get optimal
> performance on SMP.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Ben Hutchings <bhutchings@solarflare.com>

Applied, thanks Eric.

      reply	other threads:[~2013-06-11  9:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-05  5:00 [PATCH net-next] net_sched: add 64bit rate estimators Eric Dumazet
2013-06-05 18:55 ` Ben Hutchings
2013-06-05 19:37   ` Eric Dumazet
2013-06-05 20:06     ` Ben Hutchings
2013-06-05 23:07       ` Eric Dumazet
2013-06-06  8:39   ` David Laight
2013-06-06 15:43 ` [PATCH v2 " Eric Dumazet
2013-06-11  9:51   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130611.025132.157790026336411319.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bhutchings@solarflare.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox