From: Lutz Jaenicke <ljaenicke@innominate.com>
To: Michael Guntsche <michael.guntsche@it-loops.com>
Cc: Claudiu Manoil <claudiu.manoil@freescale.com>, netdev@vger.kernel.org
Subject: Re: [PATCH][net-next] gianfar: Add backwards compatible Single Queue mode polling
Date: Fri, 16 Aug 2013 13:54:56 +0200 [thread overview]
Message-ID: <20130816115456.GA16387@lutz.bln.innominate.local> (raw)
In-Reply-To: <CALG0vJtQkM65kr2-u5G578uzAFeCk5=bkKNU5BaBheXTHmc7+g@mail.gmail.com>
On Mon, Jun 10, 2013 at 07:35:38PM +0200, Michael Guntsche wrote:
> Hello Claudiu,
>
> On Mon, Jun 10, 2013 at 7:19 PM, Claudiu Manoil
> <claudiu.manoil@freescale.com> wrote:
> > Older Single Queue (SQ_SG_MODE) devices like TSEC (i.e. mpc83xx)
> > don't feature the frame receive indication bits (RXF) in RSTAT.
> > For these and for the rest of the SQ_SG_MODE devices, provide the
> > appropiate polling routine that handles a single pair of Rx/Tx
> > BD rings, removing the overhead incurred by the multiple queues/
> > multiple interrupt group devices (veTSEC/ eTSEC2.0 devices).
> > So this is primarily a fix for the TSEC devices.
> >
> > Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com>
> > ---
> > drivers/net/ethernet/freescale/gianfar.c | 51 ++++++++++++++++++++++++++++++--
> > 1 file changed, 49 insertions(+), 2 deletions(-)
> >
> <snip>
> I can confirm that this fixes the problem for my TSEC based board.
I need this fix for 3.10.7 as well, so this seems to be stable-stuff.
Best regards,
Lutz
--
Dr.-Ing. Lutz Jänicke
CTO
Innominate Security Technologies AG /protecting industrial networks/
tel: +49.30.921028-200
fax: +49.30.921028-020
Rudower Chaussee 13
D-12489 Berlin, Germany
www.innominate.com
Register Court: AG Charlottenburg, HR B 81603
Management Board: Dirk Seewald
Chairman of the Supervisory Board: Christoph Leifer
next prev parent reply other threads:[~2013-08-16 11:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CALG0vJsttWB4=fDU5yiRdf0rKgp09pY1y1jq5Ug_ra-7M7KQBQ@mail.gmail.com>
2013-06-09 20:28 ` Fwd: [BUG] Bisected Gianfar not receiving any traffic Michael Guntsche
2013-06-10 8:29 ` Claudiu Manoil
2013-06-10 8:33 ` Michael Guntsche
2013-06-10 10:03 ` Claudiu Manoil
2013-06-10 17:19 ` [PATCH][net-next] gianfar: Add backwards compatible Single Queue mode polling Claudiu Manoil
2013-06-10 17:35 ` Michael Guntsche
2013-08-16 11:54 ` Lutz Jaenicke [this message]
2013-06-12 10:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130816115456.GA16387@lutz.bln.innominate.local \
--to=ljaenicke@innominate.com \
--cc=claudiu.manoil@freescale.com \
--cc=michael.guntsche@it-loops.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox