* [PATCH] netfilter: ipvs: ip_vs_sync: Remove unused variable
@ 2013-10-07 21:09 Fabio Estevam
2013-10-28 1:04 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2013-10-07 21:09 UTC (permalink / raw)
To: horms; +Cc: ja, netdev, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Variable 'ret' is not used anywhere and it causes the following build warning:
net/netfilter/ipvs/ip_vs_sync.c: In function 'sync_thread_master':
net/netfilter/ipvs/ip_vs_sync.c:1640:8: warning: unused variable 'ret' [-Wunused-variable]
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
net/netfilter/ipvs/ip_vs_sync.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
index f63c238..d258125 100644
--- a/net/netfilter/ipvs/ip_vs_sync.c
+++ b/net/netfilter/ipvs/ip_vs_sync.c
@@ -1637,7 +1637,7 @@ static int sync_thread_master(void *data)
continue;
}
while (ip_vs_send_sync_msg(tinfo->sock, sb->mesg) < 0) {
- int ret = __wait_event_interruptible(*sk_sleep(sk),
+ __wait_event_interruptible(*sk_sleep(sk),
sock_writeable(sk) ||
kthread_should_stop());
if (unlikely(kthread_should_stop()))
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] netfilter: ipvs: ip_vs_sync: Remove unused variable
2013-10-07 21:09 [PATCH] netfilter: ipvs: ip_vs_sync: Remove unused variable Fabio Estevam
@ 2013-10-28 1:04 ` Simon Horman
2013-11-06 11:05 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2013-10-28 1:04 UTC (permalink / raw)
To: Fabio Estevam; +Cc: ja, netdev, Fabio Estevam
On Mon, Oct 07, 2013 at 06:09:02PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Variable 'ret' is not used anywhere and it causes the following build warning:
>
> net/netfilter/ipvs/ip_vs_sync.c: In function 'sync_thread_master':
> net/netfilter/ipvs/ip_vs_sync.c:1640:8: warning: unused variable 'ret' [-Wunused-variable]
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> net/netfilter/ipvs/ip_vs_sync.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
> index f63c238..d258125 100644
> --- a/net/netfilter/ipvs/ip_vs_sync.c
> +++ b/net/netfilter/ipvs/ip_vs_sync.c
> @@ -1637,7 +1637,7 @@ static int sync_thread_master(void *data)
> continue;
> }
> while (ip_vs_send_sync_msg(tinfo->sock, sb->mesg) < 0) {
> - int ret = __wait_event_interruptible(*sk_sleep(sk),
> + __wait_event_interruptible(*sk_sleep(sk),
> sock_writeable(sk) ||
> kthread_should_stop());
> if (unlikely(kthread_should_stop()))
Hi Fabio,
this patch does not seem to apply against ipvs-next.
Could you please rework it and repost if you believe it is still needed.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] netfilter: ipvs: ip_vs_sync: Remove unused variable
2013-10-28 1:04 ` Simon Horman
@ 2013-11-06 11:05 ` Fabio Estevam
0 siblings, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2013-11-06 11:05 UTC (permalink / raw)
To: Simon Horman; +Cc: ja, netdev@vger.kernel.org, Fabio Estevam
Hi Simon,
On Sun, Oct 27, 2013 at 11:04 PM, Simon Horman <horms@verge.net.au> wrote:
> Hi Fabio,
>
> this patch does not seem to apply against ipvs-next.
> Could you please rework it and repost if you believe it is still needed.
Yes, ipvs-next does not have this issue, but linux-next still shows
this problem though.
Won't ipvs-next get synced with linux-next?
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-06 11:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-07 21:09 [PATCH] netfilter: ipvs: ip_vs_sync: Remove unused variable Fabio Estevam
2013-10-28 1:04 ` Simon Horman
2013-11-06 11:05 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox