From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: netdev@vger.kernel.org, Nicolas Pitre <nico@fluxnic.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Miao <eric.y.miao@gmail.com>,
Jonathan Cameron <jic23@cam.ac.uk>,
stable@vger.kernel.org
Subject: Re: [PATCH] net: smc91: fix crash regression on the versatile
Date: Wed, 27 Nov 2013 12:13:03 +0000 [thread overview]
Message-ID: <20131127121303.GM16735@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1385553099-13874-1-git-send-email-linus.walleij@linaro.org>
On Wed, Nov 27, 2013 at 12:51:39PM +0100, Linus Walleij wrote:
> This is because the macro operations in smc91x.h are missing
> necessary #defines for operations such as SMC_inbsw(),
> SMC_outsw() and SMC_outsb() making these defined to BUG().
>
> The Versatile needs and uses the same accessors as the other
> platforms in the first if(...) clause, just switch it to using
> that and we have one problem less to worry about.
>
> This bug seems to have been around for some quite time, just
> that few people test the Versatile on real hardware, and it
> compiles.
That's a misconception. This bug is caused by:
commit e9e4ea74f06635f2ffc1dffe5ef40c854faa0a90
Author: Will Deacon <will.deacon@arm.com>
Date: Fri Oct 11 14:52:20 2013 +0100
net: smc91x: dont't use SMC_outw for fixing up halfword-aligned data
next prev parent reply other threads:[~2013-11-27 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 11:51 [PATCH] net: smc91: fix crash regression on the versatile Linus Walleij
2013-11-27 12:13 ` Russell King - ARM Linux [this message]
2013-11-27 12:28 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131127121303.GM16735@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=davem@davemloft.net \
--cc=eric.y.miao@gmail.com \
--cc=jic23@cam.ac.uk \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox