From: David Miller <davem@davemloft.net>
To: vfalico@redhat.com
Cc: netdev@vger.kernel.org, dingtianhong@huawei.com,
fubar@us.ibm.com, andy@greyhouse.net
Subject: Re: [PATCH v4 net-next 0/3] bonding: fix bond_3ad RCU usage
Date: Mon, 13 Jan 2014 22:22:52 -0800 (PST) [thread overview]
Message-ID: <20140113.222252.1955015452268147519.davem@davemloft.net> (raw)
In-Reply-To: <1389351585-19615-1-git-send-email-vfalico@redhat.com>
From: Veaceslav Falico <vfalico@redhat.com>
Date: Fri, 10 Jan 2014 11:59:42 +0100
> While digging through bond_3ad.c I've found that the RCU usage there is
> just wrong - it's used as a kind of mutex/spinlock instead of RCU.
>
> v3->v4: remove useless goto and wrap __get_first_agg() in proper RCU.
>
> v2->v3: make bond_3ad_set_carrier() use RCU read lock for the whole
> function, so that all other functions will be protected by RCU as well.
> This way we can use _rcu variants everywhere.
>
> v1->v2: use generic primitives instead of _rcu ones cause we can hold RTNL
> lock without RCU one, which is still safe.
>
> This patchset is on top of bond_3ad.c cleanup:
> http://www.spinics.net/lists/netdev/msg265447.html
Series applied, thank you.
prev parent reply other threads:[~2014-01-14 6:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 10:59 [PATCH v4 net-next 0/3] bonding: fix bond_3ad RCU usage Veaceslav Falico
2014-01-10 10:59 ` [PATCH v4 net-next 1/3] bonding: fix bond_3ad_set_carrier() " Veaceslav Falico
2014-01-10 10:59 ` [PATCH v4 net-next 2/3] bonding: fix __get_first_agg " Veaceslav Falico
2014-01-10 10:59 ` [PATCH v4 net-next 3/3] bonding: fix __get_active_agg() RCU logic Veaceslav Falico
2014-01-14 6:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113.222252.1955015452268147519.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=dingtianhong@huawei.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox