Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, therbert@google.com, maze@google.com,
	cwang@twopensource.com
Subject: Re: [PATCH net-next] ipv4: fix a dst leak in tunnels
Date: Thu, 16 Jan 2014 17:13:03 -0800 (PST)	[thread overview]
Message-ID: <20140116.171303.2113967209121208034.davem@davemloft.net> (raw)
In-Reply-To: <1389919279.31367.439.camel@edumazet-glaptop2.roam.corp.google.com>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 16 Jan 2014 16:41:19 -0800

> This patch :
> 
> 1) Remove a dst leak if DST_NOCACHE was set on dst
>    Fix this by holding a reference only if dst really cached.

Can you explain this problem a little bit more?

Why do we have to handle DST_NOCACHE specially?  We hold a reference
and dst_release() knows what to do with DST_NOCACHE routes.

Or is it semantically undesirable for tunnels to cache these routes?
If so, why do we leave sockets caching DST_NOCACHE routes just fine?

Thanks.

  reply	other threads:[~2014-01-17  1:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-17  0:41 [PATCH net-next] ipv4: fix a dst leak in tunnels Eric Dumazet
2014-01-17  1:13 ` David Miller [this message]
2014-01-17  1:29   ` Eric Dumazet
2014-01-17  1:32   ` Eric Dumazet
2014-01-17  1:40     ` David Miller
2014-01-17 22:18 ` Cong Wang
2014-01-18  2:37 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140116.171303.2113967209121208034.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=cwang@twopensource.com \
    --cc=eric.dumazet@gmail.com \
    --cc=maze@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox