From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, therbert@google.com, maze@google.com,
cwang@twopensource.com
Subject: Re: [PATCH net-next] ipv4: fix a dst leak in tunnels
Date: Thu, 16 Jan 2014 17:40:14 -0800 (PST) [thread overview]
Message-ID: <20140116.174014.415638698308506562.davem@davemloft.net> (raw)
In-Reply-To: <1389922350.31367.447.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 16 Jan 2014 17:32:30 -0800
> On Thu, 2014-01-16 at 17:13 -0800, David Miller wrote:
>
>> Why do we have to handle DST_NOCACHE specially? We hold a reference
>> and dst_release() knows what to do with DST_NOCACHE routes.
>>
>> Or is it semantically undesirable for tunnels to cache these routes?
>> If so, why do we leave sockets caching DST_NOCACHE routes just fine?
>
> If DST_NOCACHE is set on a dst, this dst cannot be used by rcu users,
> because dst_release() will immediately free the dst, without rcu grace
> period.
Ok, if we ever start using DST_NOCACHE in ipv6 we will have to modify
ipv6 tunnels as they cache similarly.
next prev parent reply other threads:[~2014-01-17 1:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 0:41 [PATCH net-next] ipv4: fix a dst leak in tunnels Eric Dumazet
2014-01-17 1:13 ` David Miller
2014-01-17 1:29 ` Eric Dumazet
2014-01-17 1:32 ` Eric Dumazet
2014-01-17 1:40 ` David Miller [this message]
2014-01-17 22:18 ` Cong Wang
2014-01-18 2:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140116.174014.415638698308506562.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cwang@twopensource.com \
--cc=eric.dumazet@gmail.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox