Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: alexander.h.duyck@redhat.com, netdev@vger.kernel.org,
	linux-usb@vger.kernel.org, leedom@chelsio.com,
	hariprasad@chelsio.com, donald.c.skidmore@intel.com,
	oliver@neukum.org, balbi@ti.com, matthew.vick@intel.com,
	mgorman@suse.de
Subject: Re: [net-next PATCH v3 4/5] fm10k/igb/ixgbe: Replace __skb_alloc_page with dev_alloc_page
Date: Tue, 11 Nov 2014 12:48:26 -0500 (EST)	[thread overview]
Message-ID: <20141111.124826.2036471212277751765.davem@davemloft.net> (raw)
In-Reply-To: <1415726904.2466.170.camel@jtkirshe-mobl>

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 11 Nov 2014 09:28:24 -0800

> On Tue, 2014-11-11 at 09:26 -0800, Alexander Duyck wrote:
>> The Intel drivers were pretty much just using the plain vanilla GFP
>> flags
>> in their calls to __skb_alloc_page so this change makes it so that
>> they use
>> dev_alloc_page which just uses GFP_ATOMIC for the gfp_flags value.
>> 
>> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>> Cc: Matthew Vick <matthew.vick@intel.com>
>> Cc: Don Skidmore <donald.c.skidmore@intel.com>
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
>> ---
>>  drivers/net/ethernet/intel/fm10k/fm10k_main.c |    2 +-
>>  drivers/net/ethernet/intel/igb/igb_main.c     |    2 +-
>>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |    3 +--
>>  3 files changed, 3 insertions(+), 4 deletions(-)
> 
> Thanks Alex, I will add the patch to my queue.

I think this entire series will need to go via my tree, because the
conversions are all required for patch #5 which removes the replaced
interface altogether.

  reply	other threads:[~2014-11-11 17:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-11 17:26 [net-next PATCH v3 0/5] Replace __skb_alloc_pages with simpler function Alexander Duyck
2014-11-11 17:26 ` [net-next PATCH v3 1/5] net: Add device Rx page allocation function Alexander Duyck
2014-11-11 17:26 ` [net-next PATCH v3 2/5] cxgb4/cxgb4vf: Replace __skb_alloc_page with __dev_alloc_page Alexander Duyck
2014-11-11 17:26 ` [net-next PATCH v3 3/5] phonet: Replace calls to " Alexander Duyck
2014-11-11 17:26 ` [net-next PATCH v3 4/5] fm10k/igb/ixgbe: Replace __skb_alloc_page with dev_alloc_page Alexander Duyck
2014-11-11 17:28   ` Jeff Kirsher
2014-11-11 17:48     ` David Miller [this message]
     [not found]       ` <20141111.124826.2036471212277751765.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-11-11 17:56         ` Jeff Kirsher
2014-11-11 17:57           ` David Miller
2014-11-11 17:27 ` [net-next PATCH v3 5/5] net: Remove __skb_alloc_page and __skb_alloc_pages Alexander Duyck
2014-11-12  5:11 ` [net-next PATCH v3 0/5] Replace __skb_alloc_pages with simpler function David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141111.124826.2036471212277751765.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alexander.h.duyck@redhat.com \
    --cc=balbi@ti.com \
    --cc=donald.c.skidmore@intel.com \
    --cc=hariprasad@chelsio.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=leedom@chelsio.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=matthew.vick@intel.com \
    --cc=mgorman@suse.de \
    --cc=netdev@vger.kernel.org \
    --cc=oliver@neukum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox