From: Alexander Duyck <alexander.h.duyck@redhat.com>
To: netdev@vger.kernel.org, linux-usb@vger.kernel.org
Cc: leedom@chelsio.com, hariprasad@chelsio.com,
donald.c.skidmore@intel.com, oliver@neukum.org, balbi@ti.com,
matthew.vick@intel.com, mgorman@suse.de, davem@davemloft.net,
jeffrey.t.kirsher@intel.com
Subject: [net-next PATCH v3 0/5] Replace __skb_alloc_pages with simpler function
Date: Tue, 11 Nov 2014 09:26:26 -0800 [thread overview]
Message-ID: <20141111172523.16460.16845.stgit@ahduyck-vm-fedora20> (raw)
This patch series replaces __skb_alloc_pages with a much simpler function,
__dev_alloc_pages. The main difference between the two is that
__skb_alloc_pages had an sk_buff pointer that was being passed as NULL in
call places where it was called. In a couple of cases the NULL was passed
by variable and this led to unnecessary code being run.
As such in order to simplify things the __dev_alloc_pages call only takes a
mask and the page order being requested. In addition it takes advantage of
several behaviors already built into the page allocator so that it can just
set GFP flags unconditionally.
v2: Renamed functions to dev_alloc_page(s) instead of netdev_alloc_page(s)
Removed __GFP_COLD flag from usb code as it was redundant
v3: Update patch descriptions and subjects to match changes in v2
---
Alexander Duyck (5):
net: Add device Rx page allocation function
cxgb4/cxgb4vf: Replace __skb_alloc_page with __dev_alloc_page
phonet: Replace calls to __skb_alloc_page with __dev_alloc_page
fm10k/igb/ixgbe: Replace __skb_alloc_page with dev_alloc_page
net: Remove __skb_alloc_page and __skb_alloc_pages
drivers/net/ethernet/chelsio/cxgb4/sge.c | 6 +-
drivers/net/ethernet/chelsio/cxgb4vf/sge.c | 7 ++-
drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 -
drivers/net/ethernet/intel/igb/igb_main.c | 2 -
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 -
drivers/net/usb/cdc-phonet.c | 6 +-
drivers/usb/gadget/function/f_phonet.c | 6 +-
include/linux/skbuff.h | 61 ++++++++++++++-----------
8 files changed, 49 insertions(+), 44 deletions(-)
--
next reply other threads:[~2014-11-11 17:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 17:26 Alexander Duyck [this message]
2014-11-11 17:26 ` [net-next PATCH v3 1/5] net: Add device Rx page allocation function Alexander Duyck
2014-11-11 17:26 ` [net-next PATCH v3 2/5] cxgb4/cxgb4vf: Replace __skb_alloc_page with __dev_alloc_page Alexander Duyck
2014-11-11 17:26 ` [net-next PATCH v3 3/5] phonet: Replace calls to " Alexander Duyck
2014-11-11 17:26 ` [net-next PATCH v3 4/5] fm10k/igb/ixgbe: Replace __skb_alloc_page with dev_alloc_page Alexander Duyck
2014-11-11 17:28 ` Jeff Kirsher
2014-11-11 17:48 ` David Miller
[not found] ` <20141111.124826.2036471212277751765.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-11-11 17:56 ` Jeff Kirsher
2014-11-11 17:57 ` David Miller
2014-11-11 17:27 ` [net-next PATCH v3 5/5] net: Remove __skb_alloc_page and __skb_alloc_pages Alexander Duyck
2014-11-12 5:11 ` [net-next PATCH v3 0/5] Replace __skb_alloc_pages with simpler function David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111172523.16460.16845.stgit@ahduyck-vm-fedora20 \
--to=alexander.h.duyck@redhat.com \
--cc=balbi@ti.com \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=hariprasad@chelsio.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=leedom@chelsio.com \
--cc=linux-usb@vger.kernel.org \
--cc=matthew.vick@intel.com \
--cc=mgorman@suse.de \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox