* [PATCH] net: qualcomm: Fix dependancy
@ 2014-11-11 21:08 Stefan Wahren
2014-11-11 21:19 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Wahren @ 2014-11-11 21:08 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
Unfortunately the patch for adding QCA7000 driver contains an old
version of Kconfig, which requires OF_GPIO. This is not necessary
anymore and need to be replaced with OF.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/net/ethernet/qualcomm/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/qualcomm/Kconfig b/drivers/net/ethernet/qualcomm/Kconfig
index f3a4714..247a287 100644
--- a/drivers/net/ethernet/qualcomm/Kconfig
+++ b/drivers/net/ethernet/qualcomm/Kconfig
@@ -5,7 +5,7 @@
config NET_VENDOR_QUALCOMM
bool "Qualcomm devices"
default y
- depends on SPI_MASTER && OF_GPIO
+ depends on SPI_MASTER && OF
---help---
If you have a network (Ethernet) card belonging to this class, say Y
and read the Ethernet-HOWTO, available from
@@ -20,7 +20,7 @@ if NET_VENDOR_QUALCOMM
config QCA7000
tristate "Qualcomm Atheros QCA7000 support"
- depends on SPI_MASTER && OF_GPIO
+ depends on SPI_MASTER && OF
---help---
This SPI protocol driver supports the Qualcomm Atheros QCA7000.
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: qualcomm: Fix dependancy
2014-11-11 21:08 [PATCH] net: qualcomm: Fix dependancy Stefan Wahren
@ 2014-11-11 21:19 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-11-11 21:19 UTC (permalink / raw)
To: stefan.wahren; +Cc: netdev
From: Stefan Wahren <stefan.wahren@i2se.com>
Date: Tue, 11 Nov 2014 21:08:30 +0000
> Unfortunately the patch for adding QCA7000 driver contains an old
> version of Kconfig, which requires OF_GPIO. This is not necessary
> anymore and need to be replaced with OF.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Actually, I would remove the dependencies entirely from the
VENDOR Kconfig entry, that makes no sense.
It's the individual drivers that need this or that, so that's where
the dependency checks belong.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-11 21:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-11 21:08 [PATCH] net: qualcomm: Fix dependancy Stefan Wahren
2014-11-11 21:19 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox