From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: hayeswang@realtek.com, netdev@vger.kernel.org,
nic_swsd@realtek.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH net] r8152: drop the tx packet with invalid length
Date: Wed, 26 Nov 2014 12:06:58 -0500 (EST) [thread overview]
Message-ID: <20141126.120658.498602780456343676.davem@davemloft.net> (raw)
In-Reply-To: <1417020748.29427.59.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 26 Nov 2014 08:52:28 -0800
> On Wed, 2014-11-26 at 17:56 +0800, Hayes Wang wrote:
>> Drop the tx packet which is more than the size of agg_buf_sz. When
>> creating a bridge with the device, we may get the tx packet with
>> TSO and the length is more than the gso_max_size which is set by
>> the driver through netif_set_gso_max_size(). Such packets couldn't
>> be transmitted and should be dropped directly.
>>
>> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
...
> Looks like a candidate for ndo_gso_check(), so that we do not drop, but
> instead segment from netif_needs_gso()/validate_xmit_skb()
You mean have the bridge implement the ndo_gso_check() method right?
next prev parent reply other threads:[~2014-11-26 17:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 9:56 [PATCH net] r8152: drop the tx packet with invalid length Hayes Wang
2014-11-26 16:52 ` Eric Dumazet
2014-11-26 17:06 ` David Miller [this message]
2014-11-26 18:44 ` Eric Dumazet
2014-11-26 20:33 ` David Miller
2014-12-19 6:42 ` Hayes Wang
2014-12-19 17:36 ` Eric Dumazet
2014-12-19 18:13 ` Eric Dumazet
2014-12-22 2:22 ` Hayes Wang
2014-12-22 11:34 ` Hayes Wang
2014-12-22 15:21 ` [PATCH net] net: ndo_gso_check() must force segmentation Eric Dumazet
2014-12-22 15:59 ` Jesse Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126.120658.498602780456343676.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox