From: Stephen Hemminger <stephen@networkplumber.org>
To: David Miller <davem@davemloft.net>,
Gregory Fong <gregory.0xf0@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org
Subject: PATCH] Revert "bridge: include in6.h in if_bridge.h for struct in6_addr"
Date: Tue, 9 Dec 2014 20:30:07 -0800 [thread overview]
Message-ID: <20141209203007.188651df@urahara> (raw)
This reverts commit 66f1c44887ba4f47d617f8ae21cf8e04e1892bd7.
iproute2 uses sanitized kernel headers, and this change broke the build.
The problem is that the iproute2 ip/iplink_bridge_slave.c include if_bridge.h
but this causes a redefintion error when Glibc <netlink/in.h> is included.
Since iproute2 is arguably the most important user of network headers,
the uapi header change should be reverted.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
Please update stable as well.
include/uapi/linux/if_bridge.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/linux/if_bridge.h
index b03ee8f..439fd0d 100644
--- a/include/uapi/linux/if_bridge.h
+++ b/include/uapi/linux/if_bridge.h
@@ -15,7 +15,6 @@
#include <linux/types.h>
#include <linux/if_ether.h>
-#include <linux/in6.h>
#define SYSFS_BRIDGE_ATTR "bridge"
#define SYSFS_BRIDGE_FDB "brforward"
--
2.1.3
next reply other threads:[~2014-12-10 4:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 4:30 Stephen Hemminger [this message]
2014-12-10 4:49 ` PATCH] Revert "bridge: include in6.h in if_bridge.h for struct in6_addr" David Miller
2014-12-10 5:41 ` [PATCH v2] if_bridge: fix conflict with glibc Stephen Hemminger
2014-12-10 18:34 ` David Miller
2014-12-10 23:57 ` Stephen Hemminger
2014-12-11 1:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209203007.188651df@urahara \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox