From: Stephen Hemminger <stephen@networkplumber.org>
To: David Miller <davem@davemloft.net>
Cc: gregory.0xf0@gmail.com, f.fainelli@gmail.com,
xiyou.wangcong@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2] if_bridge: fix conflict with glibc
Date: Wed, 10 Dec 2014 15:57:45 -0800 [thread overview]
Message-ID: <20141210155745.3d375230@urahara> (raw)
In-Reply-To: <20141210.133417.152985082992875227.davem@davemloft.net>
On Wed, 10 Dec 2014 13:34:17 -0500 (EST)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
> Date: Tue, 9 Dec 2014 21:41:22 -0800
>
> > Even though kernel and glibc headers have same effective values
> > Gcc complains about redefinitions. Since this is a header expected
> > to be used by userspace, use glibc header.
> >
> > This supersedes change in commit 66f1c44887ba4f47d617f8ae21cf8e04e1892bd7
> > and fixes build of iproute2 with Glibc-2.19. This follows similar usage
> > in include/uapi/linux for l2tp.h
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >
> > --- a/include/uapi/linux/if_bridge.h 2014-12-09 20:25:21.656016605 -0800
> > +++ b/include/uapi/linux/if_bridge.h 2014-12-09 21:32:01.391034756 -0800
> > @@ -15,7 +15,9 @@
> >
> > #include <linux/types.h>
> > #include <linux/if_ether.h>
> > -#include <linux/in6.h>
> > +#ifndef __KERNEL__
> > +#include <netinet/in.h>
> > +#endif
>
> No, we really want to incluse the linux/in6.h header, as that's where all
> the special GLIBC CPP checks are, such as:
>
> #if __UAPI_DEF_IN6_ADDR_ALT
>
> Please research how we have resolved the conflict between GLIBC and the
> kernel's exported headers. We really need to use linux/in6.h for all of
> this to work.
>
> I understand that it is upsetting that iproute2 stopped building for you,
> but I'd like to kindly ask that you look more deeply into this and think
> more longer term, rather than having a knee jerk reaction and looking for
> quick fixes.
I don't have the time to understand the intricacies of glibc headers.
The problem is that Gcc warns about duplicate definitions in headers;
this is a useful warning and not something that I want to disable.
Hacks with #undef seem to be heading the wrong way.
next prev parent reply other threads:[~2014-12-10 23:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 4:30 PATCH] Revert "bridge: include in6.h in if_bridge.h for struct in6_addr" Stephen Hemminger
2014-12-10 4:49 ` David Miller
2014-12-10 5:41 ` [PATCH v2] if_bridge: fix conflict with glibc Stephen Hemminger
2014-12-10 18:34 ` David Miller
2014-12-10 23:57 ` Stephen Hemminger [this message]
2014-12-11 1:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141210155745.3d375230@urahara \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox