* [PATCH net-next] amd-xgbe: Use disable_irq_nosync when in IRQ context
@ 2014-12-09 20:54 Tom Lendacky
2014-12-10 2:48 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Tom Lendacky @ 2014-12-09 20:54 UTC (permalink / raw)
To: netdev; +Cc: David Miller
The disable_irq_nosync function, not the disable_irq function, must be
used to disable the DMA channel interrupt from within the interrupt
service routine. Change the disable_irq call to disable_irq_nosync.
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
index bedfdb1..bf6bf11 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
@@ -396,7 +396,7 @@ static irqreturn_t xgbe_dma_isr(int irq, void *data)
*/
if (napi_schedule_prep(&channel->napi)) {
/* Disable Tx and Rx interrupts */
- disable_irq(channel->dma_irq);
+ disable_irq_nosync(channel->dma_irq);
/* Turn on polling */
__napi_schedule(&channel->napi);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-10 2:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-09 20:54 [PATCH net-next] amd-xgbe: Use disable_irq_nosync when in IRQ context Tom Lendacky
2014-12-10 2:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox