From: David Miller <davem@davemloft.net>
To: balbi@ti.com
Cc: tony@atomide.com, linux-omap@vger.kernel.org,
mugunthanvnm@ti.com, netdev@vger.kernel.org
Subject: Re: [patch-net-next 1/3] net: ethernet: cpsw: unroll IRQ request loop
Date: Wed, 14 Jan 2015 00:18:55 -0500 (EST) [thread overview]
Message-ID: <20150114.001855.480294380856199745.davem@davemloft.net> (raw)
In-Reply-To: <1421178288-7393-1-git-send-email-balbi@ti.com>
From: Felipe Balbi <balbi@ti.com>
Date: Tue, 13 Jan 2015 13:44:46 -0600
> + ret = devm_request_irq(&pdev->dev, irq, cpsw_interrupt,
> + 0, dev_name(&pdev->dev), priv);
When a function call spans multiple lines, the argument on the second
and subsequent lines must start on the first column after the openning
parenthesis of the function call.
If you are using only TAB characters to indent, you are likely not
doing it correctly.
> + ret = devm_request_irq(&pdev->dev, irq, cpsw_interrupt,
> + 0, dev_name(&pdev->dev), priv);
Likewise.
> + ret = devm_request_irq(&pdev->dev, irq, cpsw_interrupt,
> + 0, dev_name(&pdev->dev), priv);
Likewise.
> + ret = devm_request_irq(&pdev->dev, irq, cpsw_interrupt,
> + 0, dev_name(&pdev->dev), priv);
Likewise.
prev parent reply other threads:[~2015-01-14 5:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 19:44 [patch-net-next 1/3] net: ethernet: cpsw: unroll IRQ request loop Felipe Balbi
2015-01-13 19:44 ` [patch-net-next 2/3] net: ethernet: cpsw: split out IRQ handler Felipe Balbi
2015-01-13 19:44 ` [patch-net-next 3/3] net: ethernet: cpsw: don't requests IRQs we don't use Felipe Balbi
2015-01-14 5:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150114.001855.480294380856199745.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox