Bridge code in net-next does not compile

Bridge code in net-next does not compile

[Marcel Holtmann]

Hi,

when compiling net-next, the bridge code fails to compile:

  CC      net/bridge/br.o
In file included from net/bridge/br.c:22:0:
include/net/switchdev.h:73:1: error: expected identifier or ‘(’ before ‘{’ token
 {
 ^
include/net/switchdev.h:71:90: warning: ‘call_netdev_switch_notifiers’ declared ‘static’ but never defined [-Wunused-function]
 static inline int call_netdev_switch_notifiers(unsigned long val, struct net_device *dev,
                                                                                          ^

I bisecting this to this commit:

commit 03bf0c281234028388108d0aee720954f5fe6924
Author: Jiri Pirko <jiri@resnulli.us>
Date:   Thu Jan 15 23:49:36 2015 +0100

    switchdev: introduce switchdev notifier
    
    This patch introduces new notifier for purposes of exposing events which happen
    on switch driver side. The consumers of the event messages are mainly involved
    masters, namely bridge and ovs.
    
    Suggested-by: Thomas Graf <tgraf@suug.ch>
    Signed-off-by: Jiri Pirko <jiri@resnulli.us>
    Signed-off-by: Scott Feldman <sfeldma@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

Regards

Marcel

Re: Bridge code in net-next does not compile

[Jiri Pirko]

Sun, Jan 18, 2015 at 11:33:24AM CET, marcel@holtmann.org wrote:
>Hi,
>
>when compiling net-next, the bridge code fails to compile:
>
>  CC      net/bridge/br.o
>In file included from net/bridge/br.c:22:0:
>include/net/switchdev.h:73:1: error: expected identifier or ‘(’ before ‘{’ token
> {
> ^
>include/net/switchdev.h:71:90: warning: ‘call_netdev_switch_notifiers’ declared ‘static’ but never defined [-Wunused-function]
> static inline int call_netdev_switch_notifiers(unsigned long val, struct net_device *dev,

Hi, I already sent fix:

http://patchwork.ozlabs.org/patch/430160/

>                                                                                          ^
>
>I bisecting this to this commit:
>
>commit 03bf0c281234028388108d0aee720954f5fe6924
>Author: Jiri Pirko <jiri@resnulli.us>
>Date:   Thu Jan 15 23:49:36 2015 +0100
>
>    switchdev: introduce switchdev notifier
>    
>    This patch introduces new notifier for purposes of exposing events which happen
>    on switch driver side. The consumers of the event messages are mainly involved
>    masters, namely bridge and ovs.
>    
>    Suggested-by: Thomas Graf <tgraf@suug.ch>
>    Signed-off-by: Jiri Pirko <jiri@resnulli.us>
>    Signed-off-by: Scott Feldman <sfeldma@gmail.com>
>    Signed-off-by: David S. Miller <davem@davemloft.net>
>
>Regards
>
>Marcel
>
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Bridge code in net-next does not compile

[Marcel Holtmann]

Hi Jiri,

>> when compiling net-next, the bridge code fails to compile:
>> 
>> CC      net/bridge/br.o
>> In file included from net/bridge/br.c:22:0:
>> include/net/switchdev.h:73:1: error: expected identifier or ‘(’ before ‘{’ token
>> {
>> ^
>> include/net/switchdev.h:71:90: warning: ‘call_netdev_switch_notifiers’ declared ‘static’ but never defined [-Wunused-function]
>> static inline int call_netdev_switch_notifiers(unsigned long val, struct net_device *dev,
> 
> Hi, I already sent fix:
> 
> http://patchwork.ozlabs.org/patch/430160/

good. I was just building the same fix for it. Except with an actual commit message showing the error.

Next time please compile test your patches with CONFIG_NET_SWITCHDEV=n. You were adding code that depends on a kernel config option. So that should have been something obvious to actually compile test.

Dave, if you prefer a commit message with the error, then I can send my patch.

Regards

Marcel