From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: tgraf@suug.ch, eric.dumazet@gmail.com, daniel@iogearbox.net,
David.Laight@ACULAB.COM, pablo@netfilter.org, johunt@akamai.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net 2/2] rhashtable: remove indirection for grow/shrink decision functions
Date: Sat, 28 Feb 2015 00:48:40 +0000 [thread overview]
Message-ID: <20150228004840.GA18513@acer.localdomain> (raw)
In-Reply-To: <20150227.173011.720468189098021308.davem@davemloft.net>
On 27.02, David Miller wrote:
> From: "tgraf@suug.ch" <tgraf@suug.ch>
> Date: Thu, 26 Feb 2015 10:02:35 +0000
>
> > I just want to point out here that TCP is not the only future
> > use case. The station table for mac80211 has recently been
> > converted. We need to keep all of them on the radar.
>
> Just wanted to note in passing that I wonder how legal
> net/core/neighbour.c:neigh_hash_grow() is. It's growing an RCU
> hashtable without using rhashtable. :-)
I would like to note that it seem premature to convert all these
users without having the fundamental problems solved, specifically
the unbounded growing hash chains with async resizing.
It seems to me that we have enough use cases right now that problems
have become quite visible, and until we're sure they're actually
solvable for all these different use cases I'd advocate for not
moving more subsystems to use this.
next prev parent reply other threads:[~2015-02-28 0:48 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 15:31 [PATCH net 0/2] rhashtable updates Daniel Borkmann
2015-02-25 15:31 ` [PATCH net 1/2] rhashtable: unconditionally grow when max_shift is not specified Daniel Borkmann
2015-02-25 16:28 ` Thomas Graf
2015-02-25 16:36 ` Daniel Borkmann
2015-02-25 16:44 ` Daniel Borkmann
2015-02-25 17:09 ` Thomas Graf
2015-02-25 15:31 ` [PATCH net 2/2] rhashtable: remove indirection for grow/shrink decision functions Daniel Borkmann
2015-02-25 15:41 ` David Laight
2015-02-25 15:46 ` Daniel Borkmann
2015-02-25 15:51 ` David Laight
2015-02-25 16:14 ` Daniel Borkmann
2015-02-25 17:41 ` Eric Dumazet
2015-02-25 17:49 ` David Laight
2015-02-25 18:15 ` Eric Dumazet
2015-02-25 18:56 ` Daniel Borkmann
2015-02-25 19:52 ` Eric Dumazet
2015-02-25 20:10 ` Patrick McHardy
2015-02-26 10:02 ` tgraf
2015-02-27 22:30 ` David Miller
2015-02-28 0:48 ` Patrick McHardy [this message]
2015-02-28 1:35 ` David Miller
2015-02-26 14:18 ` David Laight
2015-03-11 6:42 ` Herbert Xu
2015-03-12 16:57 ` Thomas Graf
2015-03-13 7:06 ` Herbert Xu
2015-02-25 17:23 ` Thomas Graf
2015-02-27 21:06 ` [PATCH net 0/2] rhashtable updates David Miller
-- strict thread matches above, loose matches on Subject: below --
2015-02-25 22:09 [PATCH net 2/2] rhashtable: remove indirection for grow/shrink decision functions Alexei Starovoitov
2015-02-26 7:53 ` Patrick McHardy
2015-02-26 8:54 ` Daniel Borkmann
2015-02-26 14:50 ` Eric Dumazet
2015-02-26 14:54 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150228004840.GA18513@acer.localdomain \
--to=kaber@trash.net \
--cc=David.Laight@ACULAB.COM \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=johunt@akamai.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox