[PATCH net-next 2/3] bond: add support for ndo_switch_port_stp_update when bond is a bridge port

[PATCH net-next 2/3] bond: add support for ndo_switch_port_stp_update when bond is a bridge port

[roopa]

From: Roopa Prabhu <roopa@cumulusnetworks.com>

This patch adds support for stp state offload netdev op to support the case
where bond is a bridge port and bond slaves are switch ports.

Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
---
 drivers/net/bonding/bond_main.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 675b082..bf60535 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -4005,6 +4005,7 @@ static const struct net_device_ops bond_netdev_ops = {
 	.ndo_fix_features	= bond_fix_features,
 	.ndo_bridge_setlink	= ndo_dflt_netdev_switch_port_bridge_setlink,
 	.ndo_bridge_dellink	= ndo_dflt_netdev_switch_port_bridge_dellink,
+	.ndo_switch_port_stp_update = ndo_dflt_netdev_switch_port_stp_update,
 };
 
 static const struct device_type bond_type = {
-- 
1.7.10.4

Re: [PATCH net-next 2/3] bond: add support for ndo_switch_port_stp_update when bond is a bridge port

[Jiri Pirko]

Fri, Mar 06, 2015 at 05:04:17AM CET, roopa@cumulusnetworks.com wrote:
>From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
>This patch adds support for stp state offload netdev op to support the case
>where bond is a bridge port and bond slaves are switch ports.
>
>Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>

Maybe the indent should be fixed for the rest to align with
.ndo_switch_port_stp_update. Not sure if that is needed thought. The
same note goes for team.

Acked-by: Jiri Pirko <jiri@resnulli.us>

>---
> drivers/net/bonding/bond_main.c |    1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index 675b082..bf60535 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -4005,6 +4005,7 @@ static const struct net_device_ops bond_netdev_ops = {
> 	.ndo_fix_features	= bond_fix_features,
> 	.ndo_bridge_setlink	= ndo_dflt_netdev_switch_port_bridge_setlink,
> 	.ndo_bridge_dellink	= ndo_dflt_netdev_switch_port_bridge_dellink,
>+	.ndo_switch_port_stp_update = ndo_dflt_netdev_switch_port_stp_update,
> };
> 
> static const struct device_type bond_type = {
>-- 
>1.7.10.4
>

Re: [PATCH net-next 2/3] bond: add support for ndo_switch_port_stp_update when bond is a bridge port

[roopa]

On 3/5/15, 10:55 PM, Jiri Pirko wrote:
> Fri, Mar 06, 2015 at 05:04:17AM CET, roopa@cumulusnetworks.com wrote:
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> This patch adds support for stp state offload netdev op to support the case
>> where bond is a bridge port and bond slaves are switch ports.
>>
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> Maybe the indent should be fixed for the rest to align with
> .ndo_switch_port_stp_update. Not sure if that is needed thought. The
> same note goes for team.
Thanks Jiri. I looked at it and you are right i am not sure i can do 
anything more.
>
> Acked-by: Jiri Pirko <jiri@resnulli.us>
>
>> ---
>> drivers/net/bonding/bond_main.c |    1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>> index 675b082..bf60535 100644
>> --- a/drivers/net/bonding/bond_main.c
>> +++ b/drivers/net/bonding/bond_main.c
>> @@ -4005,6 +4005,7 @@ static const struct net_device_ops bond_netdev_ops = {
>> 	.ndo_fix_features	= bond_fix_features,
>> 	.ndo_bridge_setlink	= ndo_dflt_netdev_switch_port_bridge_setlink,
>> 	.ndo_bridge_dellink	= ndo_dflt_netdev_switch_port_bridge_dellink,
>> +	.ndo_switch_port_stp_update = ndo_dflt_netdev_switch_port_stp_update,
>> };
>>
>> static const struct device_type bond_type = {
>> -- 
>> 1.7.10.4
>>