* netlink: Remove max_size setting
@ 2015-05-01 0:27 Herbert Xu
2015-05-01 4:23 ` Thomas Graf
2015-05-04 3:27 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Herbert Xu @ 2015-05-01 0:27 UTC (permalink / raw)
To: David S. Miller, Thomas Graf, netdev
We currently limit the hash table size to 64K which is very bad
as even 10 years ago it was relatively easy to generate millions
of sockets.
Since the hash table is naturally limited by memory allocation
failure, we don't really need an explicit limit so this patch
removes it.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index ec4adbd..daa0b81 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -3139,7 +3139,6 @@ static const struct rhashtable_params netlink_rhashtable_params = {
.key_len = netlink_compare_arg_len,
.obj_hashfn = netlink_hash,
.obj_cmpfn = netlink_compare,
- .max_size = 65536,
.automatic_shrinking = true,
};
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: netlink: Remove max_size setting
2015-05-01 0:27 netlink: Remove max_size setting Herbert Xu
@ 2015-05-01 4:23 ` Thomas Graf
2015-05-04 3:27 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Graf @ 2015-05-01 4:23 UTC (permalink / raw)
To: Herbert Xu; +Cc: David S. Miller, netdev
On 05/01/15 at 08:27am, Herbert Xu wrote:
> We currently limit the hash table size to 64K which is very bad
> as even 10 years ago it was relatively easy to generate millions
> of sockets.
>
> Since the hash table is naturally limited by memory allocation
> failure, we don't really need an explicit limit so this patch
> removes it.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Thomas Graf <tgraf@noironetworks.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: netlink: Remove max_size setting
2015-05-01 0:27 netlink: Remove max_size setting Herbert Xu
2015-05-01 4:23 ` Thomas Graf
@ 2015-05-04 3:27 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-05-04 3:27 UTC (permalink / raw)
To: herbert; +Cc: tgraf, netdev
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 1 May 2015 08:27:59 +0800
> We currently limit the hash table size to 64K which is very bad
> as even 10 years ago it was relatively easy to generate millions
> of sockets.
>
> Since the hash table is naturally limited by memory allocation
> failure, we don't really need an explicit limit so this patch
> removes it.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks Herbert.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-04 3:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-01 0:27 netlink: Remove max_size setting Herbert Xu
2015-05-01 4:23 ` Thomas Graf
2015-05-04 3:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox