public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: bernhard.thaler@wvnet.at
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [PATCHv2] bridge: change BR_GROUPFWD_RESTRICTED to allow forwarding of LLDP frames
Date: Tue, 05 May 2015 19:21:17 -0400 (EDT)	[thread overview]
Message-ID: <20150505.192117.1979417987836600141.davem@davemloft.net> (raw)
In-Reply-To: <1430772433-16384-1-git-send-email-bernhard.thaler@wvnet.at>

From: Bernhard Thaler <bernhard.thaler@wvnet.at>
Date: Mon,  4 May 2015 22:47:13 +0200

> BR_GROUPFWD_RESTRICTED bitmask restricts users from setting values to
> /sys/class/net/brX/bridge/group_fwd_mask that allow forwarding of
> some IEEE 802.1D Table 7-10 Reserved addresses:
> 
> 	(MAC Control) 802.3		01-80-C2-00-00-01
> 	(Link Aggregation) 802.3	01-80-C2-00-00-02
> 	802.1AB LLDP			01-80-C2-00-00-0E
> 
> Change BR_GROUPFWD_RESTRICTED to allow to forward LLDP frames and document
> group_fwd_mask.
> 
> e.g.
>    echo 16384 > /sys/class/net/brX/bridge/group_fwd_mask
> allows to forward LLDP frames.
> 
> This may be needed for bridge setups used for network troubleshooting or
> any other scenario where forwarding of LLDP frames is desired (e.g. bridge
> connecting a virtual machine to real switch transmitting LLDP frames that
> virtual machine needs to receive).
> 
> Tested on a simple bridge setup with two interfaces and host transmitting
> LLDP frames on one side of this bridge (used lldpd). Setting group_fwd_mask
> as described above lets LLDP frames traverse bridge.
> 
> Signed-off-by: Bernhard Thaler <bernhard.thaler@wvnet.at>

Applied, thanks.

      reply	other threads:[~2015-05-05 23:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-22 22:24 [RFC 1/1] bridge: relax BR_GROUPFWD_RESTRICTED to forward LLDP frames Bernhard Thaler
2015-03-29 22:06 ` [PATCH] " Bernhard Thaler
2015-04-01 19:28   ` David Miller
2015-04-01 21:03     ` Bernhard Thaler
2015-04-01 22:50       ` Stephen Hemminger
2015-05-04 20:47         ` [PATCHv2] bridge: change BR_GROUPFWD_RESTRICTED to allow forwarding of " Bernhard Thaler
2015-05-05 23:21           ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150505.192117.1979417987836600141.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bernhard.thaler@wvnet.at \
    --cc=bridge@lists.linux-foundation.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox