From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: David Binderman <dcb314@hotmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: linux-4.2-rc1/samples/bpf/sockex3_kern.c: bad expression ?
Date: Tue, 7 Jul 2015 12:14:38 -0700 [thread overview]
Message-ID: <20150707191437.GA6040@Alexeis-MBP.westell.com> (raw)
In-Reply-To: <DUB128-W38D412CB6F86AA3D6084F49C920@phx.gbl>
On Tue, Jul 07, 2015 at 11:27:55AM +0000, David Binderman wrote:
> Hello there,
>
> [linux-4.2-rc1/samples/bpf/sockex3_kern.c:268]: (style) Expression '(X & 0xf0) == 0x4' is always false.
>
> Source code is
>
> if ((verlen & 0xF0) == 4)
>
> Maybe
>
> if ((verlen & 0xF0) == 0x40)
oops, yes. Could you please send a patch to fix it. Thx
next prev parent reply other threads:[~2015-07-07 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 11:27 linux-4.2-rc1/samples/bpf/sockex3_kern.c: bad expression ? David Binderman
2015-07-07 19:14 ` Alexei Starovoitov [this message]
2015-07-07 19:24 ` David Binderman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150707191437.GA6040@Alexeis-MBP.westell.com \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=dcb314@hotmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox