* linux-4.2-rc1/samples/bpf/sockex3_kern.c: bad expression ?
@ 2015-07-07 11:27 David Binderman
2015-07-07 19:14 ` Alexei Starovoitov
0 siblings, 1 reply; 3+ messages in thread
From: David Binderman @ 2015-07-07 11:27 UTC (permalink / raw)
To: Alexei Starovoitov, netdev@vger.kernel.org
Hello there,
[linux-4.2-rc1/samples/bpf/sockex3_kern.c:268]: (style) Expression '(X & 0xf0) == 0x4' is always false.
Source code is
if ((verlen & 0xF0) == 4)
Maybe
if ((verlen & 0xF0) == 0x40)
Regards
David Binderman
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-4.2-rc1/samples/bpf/sockex3_kern.c: bad expression ?
2015-07-07 11:27 linux-4.2-rc1/samples/bpf/sockex3_kern.c: bad expression ? David Binderman
@ 2015-07-07 19:14 ` Alexei Starovoitov
2015-07-07 19:24 ` David Binderman
0 siblings, 1 reply; 3+ messages in thread
From: Alexei Starovoitov @ 2015-07-07 19:14 UTC (permalink / raw)
To: David Binderman; +Cc: Alexei Starovoitov, netdev@vger.kernel.org
On Tue, Jul 07, 2015 at 11:27:55AM +0000, David Binderman wrote:
> Hello there,
>
> [linux-4.2-rc1/samples/bpf/sockex3_kern.c:268]: (style) Expression '(X & 0xf0) == 0x4' is always false.
>
> Source code is
>
> if ((verlen & 0xF0) == 4)
>
> Maybe
>
> if ((verlen & 0xF0) == 0x40)
oops, yes. Could you please send a patch to fix it. Thx
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: linux-4.2-rc1/samples/bpf/sockex3_kern.c: bad expression ?
2015-07-07 19:14 ` Alexei Starovoitov
@ 2015-07-07 19:24 ` David Binderman
0 siblings, 0 replies; 3+ messages in thread
From: David Binderman @ 2015-07-07 19:24 UTC (permalink / raw)
To: Alexei Starovoitov; +Cc: Alexei Starovoitov, netdev@vger.kernel.org
Hello there Alexei,
----------------------------------------
> oops, yes. Could you please send a patch to fix it.
Sorry, but I gave up trying to do kernel patches many years ago.
Regards
David Binderman
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-07 19:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-07 11:27 linux-4.2-rc1/samples/bpf/sockex3_kern.c: bad expression ? David Binderman
2015-07-07 19:14 ` Alexei Starovoitov
2015-07-07 19:24 ` David Binderman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox