* [PATCH net-next] openvswitch: fix compilation when vxlan is a module
@ 2015-07-23 9:29 Nicolas Dichtel
2015-07-23 9:52 ` Thomas Graf
2015-07-27 3:57 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Nicolas Dichtel @ 2015-07-23 9:29 UTC (permalink / raw)
To: davem; +Cc: netdev, pshelar, dev, Nicolas Dichtel, Thomas Graf
With CONFIG_VXLAN=m and CONFIG_OPENVSWITCH=y, there was the following
compilation error:
LD init/built-in.o
net/built-in.o: In function `vxlan_tnl_create':
.../net/openvswitch/vport-netdev.c:322: undefined reference to `vxlan_dev_create'
make: *** [vmlinux] Error 1
CC: Thomas Graf <tgraf@suug.ch>
Fixes: 614732eaa12d ("openvswitch: Use regular VXLAN net_device device")
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
net/openvswitch/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/openvswitch/Kconfig b/net/openvswitch/Kconfig
index 1119f46b80b4..6ed1d2da9fcd 100644
--- a/net/openvswitch/Kconfig
+++ b/net/openvswitch/Kconfig
@@ -5,6 +5,7 @@
config OPENVSWITCH
tristate "Open vSwitch"
depends on INET
+ depends on VXLAN
select LIBCRC32C
select MPLS
select NET_MPLS_GSO
--
2.4.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] openvswitch: fix compilation when vxlan is a module
2015-07-23 9:29 [PATCH net-next] openvswitch: fix compilation when vxlan is a module Nicolas Dichtel
@ 2015-07-23 9:52 ` Thomas Graf
2015-07-27 3:57 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Graf @ 2015-07-23 9:52 UTC (permalink / raw)
To: Nicolas Dichtel; +Cc: davem, netdev, pshelar, dev
On 07/23/15 at 11:29am, Nicolas Dichtel wrote:
> With CONFIG_VXLAN=m and CONFIG_OPENVSWITCH=y, there was the following
> compilation error:
> LD init/built-in.o
> net/built-in.o: In function `vxlan_tnl_create':
> .../net/openvswitch/vport-netdev.c:322: undefined reference to `vxlan_dev_create'
> make: *** [vmlinux] Error 1
>
> CC: Thomas Graf <tgraf@suug.ch>
> Fixes: 614732eaa12d ("openvswitch: Use regular VXLAN net_device device")
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Thanks!
Acked-by: Thomas Graf <tgraf@suug.ch>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] openvswitch: fix compilation when vxlan is a module
2015-07-23 9:29 [PATCH net-next] openvswitch: fix compilation when vxlan is a module Nicolas Dichtel
2015-07-23 9:52 ` Thomas Graf
@ 2015-07-27 3:57 ` David Miller
2015-07-27 8:33 ` Thomas Graf
1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2015-07-27 3:57 UTC (permalink / raw)
To: nicolas.dichtel; +Cc: netdev, pshelar, dev, tgraf
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Thu, 23 Jul 2015 11:29:07 +0200
> With CONFIG_VXLAN=m and CONFIG_OPENVSWITCH=y, there was the following
> compilation error:
> LD init/built-in.o
> net/built-in.o: In function `vxlan_tnl_create':
> .../net/openvswitch/vport-netdev.c:322: undefined reference to `vxlan_dev_create'
> make: *** [vmlinux] Error 1
>
> CC: Thomas Graf <tgraf@suug.ch>
> Fixes: 614732eaa12d ("openvswitch: Use regular VXLAN net_device device")
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Applied as a stop-gap measure to fix this, but this is a terrible
dependency.
There is no reason a user should have to know that without vxlan
they aren't able to turn on openvswitch.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] openvswitch: fix compilation when vxlan is a module
2015-07-27 3:57 ` David Miller
@ 2015-07-27 8:33 ` Thomas Graf
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Graf @ 2015-07-27 8:33 UTC (permalink / raw)
To: David Miller; +Cc: nicolas.dichtel, netdev, pshelar, dev
On 07/26/15 at 08:57pm, David Miller wrote:
> From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> Date: Thu, 23 Jul 2015 11:29:07 +0200
>
> > With CONFIG_VXLAN=m and CONFIG_OPENVSWITCH=y, there was the following
> > compilation error:
> > LD init/built-in.o
> > net/built-in.o: In function `vxlan_tnl_create':
> > .../net/openvswitch/vport-netdev.c:322: undefined reference to `vxlan_dev_create'
> > make: *** [vmlinux] Error 1
> >
> > CC: Thomas Graf <tgraf@suug.ch>
> > Fixes: 614732eaa12d ("openvswitch: Use regular VXLAN net_device device")
> > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
>
> Applied as a stop-gap measure to fix this, but this is a terrible
> dependency.
>
> There is no reason a user should have to know that without vxlan
> they aren't able to turn on openvswitch.
I'm working on a patch to re-enable this choice.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-27 8:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-23 9:29 [PATCH net-next] openvswitch: fix compilation when vxlan is a module Nicolas Dichtel
2015-07-23 9:52 ` Thomas Graf
2015-07-27 3:57 ` David Miller
2015-07-27 8:33 ` Thomas Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox