From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: xiyou.wangcong@gmail.com, john.fastabend@gmail.com,
netdev@vger.kernel.org, daniel@iogearbox.net
Subject: Re: [PATCH] net: sched: fix missing free per cpu on qstats
Date: Wed, 06 Jan 2016 01:41:21 -0500 (EST) [thread overview]
Message-ID: <20160106.014121.2086606632987547429.davem@davemloft.net> (raw)
In-Reply-To: <1452049669.8255.157.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 05 Jan 2016 19:07:49 -0800
> On Tue, 2016-01-05 at 18:49 -0800, Cong Wang wrote:
>> On Tue, Jan 5, 2016 at 9:44 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> > On Tue, 2016-01-05 at 09:11 -0800, John Fastabend wrote:
>> >> When a qdisc is using per cpu stats (currently just the ingress
>> >> qdisc) only the bstats are being freed. This also free's the qstats.
>> >>
>> >> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
>> >> ---
>> >
>> > Acked-by: Eric Dumazet <edumazet@google.com>
>> >
>> > David, please add the following tag to ease backports to stable kernels:
>> >
>> > Fixes: 22e0f8b9322cb ("net: sched: make bstats per cpu and estimator RCU safe")
>> >
>>
>> Not a big deal at all but... doesn't that fix commit b0ab6f92752b9f9d8
>> instead of 22e0f8b9322cb?
>
> Hmmm... you may be right. Both were added in 3.18.
>
> My search was based on commit adding qdisc_is_percpu_stats()
The right commit looks to be b0ab6f92752b9f9d8, so that's what I've
used in the Fixes: tag.
Applied and queued up for -stable, thanks!
next prev parent reply other threads:[~2016-01-06 6:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 17:11 [PATCH] net: sched: fix missing free per cpu on qstats John Fastabend
2016-01-05 17:44 ` Eric Dumazet
2016-01-05 19:14 ` David Miller
2016-01-06 2:49 ` Cong Wang
2016-01-06 3:07 ` Eric Dumazet
2016-01-06 6:41 ` David Miller [this message]
2016-01-05 18:00 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106.014121.2086606632987547429.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@iogearbox.net \
--cc=eric.dumazet@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox