* [PATCH] net: ethernet: tundra: Correct argument for pci_free_consistent
@ 2016-06-27 9:04 Amitoj Kaur Chawla
2016-06-29 8:09 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Amitoj Kaur Chawla @ 2016-06-27 9:04 UTC (permalink / raw)
To: netdev, linux-kernel; +Cc: julia.lawall
pci_free_consistent's argument 'struct pci_dev' should be NULL not 0.
The Coccinelle semantic patch used to make this change is as follows:
@@
@@
pci_free_consistent(
- 0
+ NULL
, ...)
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/net/ethernet/tundra/tsi108_eth.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/tundra/tsi108_eth.c b/drivers/net/ethernet/tundra/tsi108_eth.c
index 520cf50..01a7714 100644
--- a/drivers/net/ethernet/tundra/tsi108_eth.c
+++ b/drivers/net/ethernet/tundra/tsi108_eth.c
@@ -1314,7 +1314,8 @@ static int tsi108_open(struct net_device *dev)
data->txring = dma_zalloc_coherent(NULL, txring_size, &data->txdma,
GFP_KERNEL);
if (!data->txring) {
- pci_free_consistent(0, rxring_size, data->rxring, data->rxdma);
+ pci_free_consistent(NULL, rxring_size, data->rxring,
+ data->rxdma);
return -ENOMEM;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ethernet: tundra: Correct argument for pci_free_consistent
2016-06-27 9:04 [PATCH] net: ethernet: tundra: Correct argument for pci_free_consistent Amitoj Kaur Chawla
@ 2016-06-29 8:09 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-06-29 8:09 UTC (permalink / raw)
To: amitoj1606; +Cc: netdev, linux-kernel, julia.lawall
From: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Date: Mon, 27 Jun 2016 14:34:50 +0530
> pci_free_consistent's argument 'struct pci_dev' should be NULL not 0.
>
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> @@
>
> pci_free_consistent(
> - 0
> + NULL
> , ...)
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
This patch doesn't apply.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-29 8:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-27 9:04 [PATCH] net: ethernet: tundra: Correct argument for pci_free_consistent Amitoj Kaur Chawla
2016-06-29 8:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox