From: Thomas Graf <tgraf@suug.ch>
To: Jiri Kosina <jikos@kernel.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Jamal Hadi Salim <jhs@mojatatu.com>, Phil Sutter <phil@nwl.cc>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2] net: sched: convert qdisc linked list to hashtable
Date: Fri, 8 Jul 2016 13:07:17 +0200 [thread overview]
Message-ID: <20160708110717.GA13885@pox.localdomain> (raw)
In-Reply-To: <alpine.LNX.2.00.1607072234190.24757@cbobk.fhfr.pm>
On 07/07/16 at 10:36pm, Jiri Kosina wrote:
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index f45929c..630838e 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -52,6 +52,7 @@
> #include <uapi/linux/netdevice.h>
> #include <uapi/linux/if_bonding.h>
> #include <uapi/linux/pkt_cls.h>
> +#include <linux/hashtable.h>
>
> struct netpoll_info;
> struct device;
> @@ -1778,6 +1779,7 @@ struct net_device {
> unsigned int num_tx_queues;
> unsigned int real_num_tx_queues;
> struct Qdisc *qdisc;
> + DECLARE_HASHTABLE (qdisc_hash, 16);
This blows up net_device to an insane size: 64K * sizeof(struct
hlist_head). Can we allocate this on demand for net_devices where
it is actually needed? The majority of virtual devices won't need
this. Doesn't have to be rhashtable, can still be fixed size but
at least allocate it.
next prev parent reply other threads:[~2016-07-08 11:07 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 14:44 Deleting child qdisc doesn't reset parent to default qdisc? Jiri Kosina
2016-04-14 14:51 ` Jiri Kosina
2016-04-14 15:01 ` Eric Dumazet
2016-04-14 15:18 ` Phil Sutter
2016-04-14 15:34 ` Jiri Kosina
2016-04-14 15:44 ` Eric Dumazet
2016-04-14 16:22 ` Phil Sutter
2016-04-14 16:40 ` Eric Dumazet
2016-04-14 16:08 ` Jiri Kosina
2016-04-14 17:49 ` Eric Dumazet
2016-04-15 12:42 ` Jamal Hadi Salim
2016-04-15 14:58 ` Eric Dumazet
2016-04-15 17:13 ` David Miller
2016-06-28 15:19 ` Jiri Kosina
2016-06-28 17:28 ` Cong Wang
2016-06-28 17:33 ` Jiri Kosina
2016-06-28 16:49 ` [RFC PATCH] sch_tbf: avoid silent fallback to noop_qdisc (was Re: Deleting child qdisc doesn't reset parent to default qdisc?) Jiri Kosina
2016-07-07 9:04 ` [RFC PATCH] net: sched: convert qdisc linked list to hashtable " Jiri Kosina
2016-07-07 13:51 ` Eric Dumazet
2016-07-07 16:32 ` Jiri Kosina
2016-07-07 16:53 ` Eric Dumazet
2016-07-07 20:36 ` [RFC PATCH v2] net: sched: convert qdisc linked list to hashtable Jiri Kosina
2016-07-08 8:50 ` Eric Dumazet
2016-07-08 9:02 ` Jiri Kosina
2016-07-08 11:07 ` Thomas Graf [this message]
2016-07-08 13:52 ` Eric Dumazet
2016-07-11 14:02 ` [RFC PATCH v3] " Jiri Kosina
2016-07-12 17:36 ` Cong Wang
2016-07-13 13:47 ` Jiri Kosina
2016-07-28 9:56 ` [PATCH v4] " Jiri Kosina
2016-07-28 11:10 ` kbuild test robot
2016-07-28 11:18 ` Jiri Kosina
2016-07-28 12:53 ` Fengguang Wu
2016-07-28 16:53 ` Cong Wang
2016-07-31 11:21 ` Fengguang Wu
2016-08-01 10:12 ` Jiri Kosina
2016-07-28 11:22 ` kbuild test robot
2016-07-28 11:52 ` kbuild test robot
2016-07-28 16:52 ` Cong Wang
2016-07-29 7:49 ` [PATCH v5] " Jiri Kosina
2016-07-29 20:01 ` kbuild test robot
2016-07-31 0:11 ` kbuild test robot
2016-08-01 10:23 ` [PATCH v6] " Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2016-07-07 22:57 [RFC PATCH v2] " Craig Gallek
2016-07-08 8:11 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160708110717.GA13885@pox.localdomain \
--to=tgraf@suug.ch \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox