From: Jiri Kosina <jikos@kernel.org>
To: Craig Gallek <kraigatgoog@gmail.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Jamal Hadi Salim <jhs@mojatatu.com>, Phil Sutter <phil@nwl.cc>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v2] net: sched: convert qdisc linked list to hashtable
Date: Fri, 8 Jul 2016 10:11:26 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1607081008460.24757@cbobk.fhfr.pm> (raw)
In-Reply-To: <CAEfhGizOVjafBpH8K0+57cyN_ySKqChYRw8jrfV=ODM5nmnvmA@mail.gmail.com>
On Thu, 7 Jul 2016, Craig Gallek wrote:
> This sort of seems like it's just side-stepping the problem. Given
> that the size of this hash table is fixed, the lookup time of this
> operation is still going to approach linear as the number of qdiscs
> increases.
That's true; however the primary goal here is not to actually ultimately
improve speed of qdisc lookup per se, but rather to make it possible to
unhide the qdiscs which are currently omitted as the linked list takes too
long to walk. The static hashtable is going help here.
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2016-07-08 8:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 22:57 [RFC PATCH v2] net: sched: convert qdisc linked list to hashtable Craig Gallek
2016-07-08 8:11 ` Jiri Kosina [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-04-14 14:44 Deleting child qdisc doesn't reset parent to default qdisc? Jiri Kosina
2016-04-14 15:01 ` Eric Dumazet
2016-04-14 15:18 ` Phil Sutter
2016-04-14 16:08 ` Jiri Kosina
2016-04-14 17:49 ` Eric Dumazet
2016-04-15 12:42 ` Jamal Hadi Salim
2016-04-15 14:58 ` Eric Dumazet
2016-07-07 9:04 ` [RFC PATCH] net: sched: convert qdisc linked list to hashtable (was Re: Deleting child qdisc doesn't reset parent to default qdisc?) Jiri Kosina
2016-07-07 20:36 ` [RFC PATCH v2] net: sched: convert qdisc linked list to hashtable Jiri Kosina
2016-07-08 8:50 ` Eric Dumazet
2016-07-08 9:02 ` Jiri Kosina
2016-07-08 11:07 ` Thomas Graf
2016-07-08 13:52 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1607081008460.24757@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=kraigatgoog@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox