* [PATCH net-next] mlxsw: spectrum: Make offloads stats functions static
@ 2016-09-20 5:14 Or Gerlitz
2016-09-20 7:55 ` Jiri Pirko
2016-09-21 4:49 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Or Gerlitz @ 2016-09-20 5:14 UTC (permalink / raw)
To: David S. Miller; +Cc: Jiri Pirko, Nogah Frankel, netdev, Or Gerlitz
The offloads stats functions are local to this file, make them static.
Fixes: fc1bbb0f1831 ('mlxsw: spectrum: Implement offload stats ndo [..]')
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
index 171f8dd..efac909 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
@@ -819,7 +819,7 @@ err_span_port_mtu_update:
return err;
}
-int
+static int
mlxsw_sp_port_get_sw_stats64(const struct net_device *dev,
struct rtnl_link_stats64 *stats)
{
@@ -851,7 +851,7 @@ mlxsw_sp_port_get_sw_stats64(const struct net_device *dev,
return 0;
}
-bool mlxsw_sp_port_has_offload_stats(int attr_id)
+static bool mlxsw_sp_port_has_offload_stats(int attr_id)
{
switch (attr_id) {
case IFLA_OFFLOAD_XSTATS_CPU_HIT:
@@ -861,8 +861,8 @@ bool mlxsw_sp_port_has_offload_stats(int attr_id)
return false;
}
-int mlxsw_sp_port_get_offload_stats(int attr_id, const struct net_device *dev,
- void *sp)
+static int mlxsw_sp_port_get_offload_stats(int attr_id, const struct net_device *dev,
+ void *sp)
{
switch (attr_id) {
case IFLA_OFFLOAD_XSTATS_CPU_HIT:
--
2.3.7
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] mlxsw: spectrum: Make offloads stats functions static
2016-09-20 5:14 [PATCH net-next] mlxsw: spectrum: Make offloads stats functions static Or Gerlitz
@ 2016-09-20 7:55 ` Jiri Pirko
2016-09-21 4:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2016-09-20 7:55 UTC (permalink / raw)
To: Or Gerlitz; +Cc: David S. Miller, Jiri Pirko, Nogah Frankel, netdev
Tue, Sep 20, 2016 at 07:14:08AM CEST, ogerlitz@mellanox.com wrote:
>The offloads stats functions are local to this file, make them static.
>
>Fixes: fc1bbb0f1831 ('mlxsw: spectrum: Implement offload stats ndo [..]')
>Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] mlxsw: spectrum: Make offloads stats functions static
2016-09-20 5:14 [PATCH net-next] mlxsw: spectrum: Make offloads stats functions static Or Gerlitz
2016-09-20 7:55 ` Jiri Pirko
@ 2016-09-21 4:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-09-21 4:49 UTC (permalink / raw)
To: ogerlitz; +Cc: jiri, nogahf, netdev
From: Or Gerlitz <ogerlitz@mellanox.com>
Date: Tue, 20 Sep 2016 08:14:08 +0300
> The offloads stats functions are local to this file, make them static.
>
> Fixes: fc1bbb0f1831 ('mlxsw: spectrum: Implement offload stats ndo [..]')
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-21 4:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-20 5:14 [PATCH net-next] mlxsw: spectrum: Make offloads stats functions static Or Gerlitz
2016-09-20 7:55 ` Jiri Pirko
2016-09-21 4:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox