From: David Miller <davem@davemloft.net>
To: Yuval.Mintz@cavium.com
Cc: arnd@arndb.de, Yuval.Mintz@qlogic.com, Ariel.Elior@qlogic.com,
everest-linux-l2@qlogic.com, Ram.Amrani@cavium.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] qed: fix old-style function definition
Date: Thu, 13 Oct 2016 10:53:18 -0400 (EDT) [thread overview]
Message-ID: <20161013.105318.2208635604910378202.davem@davemloft.net> (raw)
In-Reply-To: <BL2PR07MB230694B607619C4DFBB90B7F8DDC0@BL2PR07MB2306.namprd07.prod.outlook.com>
From: "Mintz, Yuval" <Yuval.Mintz@cavium.com>
Date: Thu, 13 Oct 2016 14:15:51 +0000
>> > The definition of qed_get_rdma_ops() is not a prototype unless we add
>> > 'void' here, as indicated by this W=1 warning:
>> >
>> > drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ‘qed_get_rdma_ops’:
>> > drivers/net/ethernet/qlogic/qed/qed_roce.c:2950:28: error: old-style
>> > function definition [-Werror=old-style-definition]
>> >
>> > Fixes: abd49676c707 ("qed: Add RoCE ll2 & GSI support")
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Again, Qlogic folks, please properly review patches posted against your driver.
>>
>> Thanks.
>
> Sorry, managed to miss this one.
> Acked-by: Yuval Mintz <Yuval.Mintz@caviumnetworks.com>
Applied.
prev parent reply other threads:[~2016-10-13 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 11:59 [PATCH] qed: fix old-style function definition Arnd Bergmann
2016-10-13 13:55 ` David Miller
2016-10-13 14:15 ` Mintz, Yuval
2016-10-13 14:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013.105318.2208635604910378202.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ariel.Elior@qlogic.com \
--cc=Ram.Amrani@cavium.com \
--cc=Yuval.Mintz@cavium.com \
--cc=Yuval.Mintz@qlogic.com \
--cc=arnd@arndb.de \
--cc=everest-linux-l2@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox