* [PATCH] qed: fix old-style function definition
@ 2016-10-10 11:59 Arnd Bergmann
2016-10-13 13:55 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2016-10-10 11:59 UTC (permalink / raw)
To: Yuval Mintz, Ariel Elior, everest-linux-l2
Cc: Arnd Bergmann, Ram Amrani, David S. Miller, netdev, linux-kernel
The definition of qed_get_rdma_ops() is not a prototype unless
we add 'void' here, as indicated by this W=1 warning:
drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ‘qed_get_rdma_ops’:
drivers/net/ethernet/qlogic/qed/qed_roce.c:2950:28: error: old-style function definition [-Werror=old-style-definition]
Fixes: abd49676c707 ("qed: Add RoCE ll2 & GSI support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/qlogic/qed/qed_roce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_roce.c b/drivers/net/ethernet/qlogic/qed/qed_roce.c
index 23430059471c..76831a398bed 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_roce.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_roce.c
@@ -2947,7 +2947,7 @@ static const struct qed_rdma_ops qed_rdma_ops_pass = {
.roce_ll2_stats = &qed_roce_ll2_stats,
};
-const struct qed_rdma_ops *qed_get_rdma_ops()
+const struct qed_rdma_ops *qed_get_rdma_ops(void)
{
return &qed_rdma_ops_pass;
}
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] qed: fix old-style function definition
2016-10-10 11:59 [PATCH] qed: fix old-style function definition Arnd Bergmann
@ 2016-10-13 13:55 ` David Miller
2016-10-13 14:15 ` Mintz, Yuval
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2016-10-13 13:55 UTC (permalink / raw)
To: arnd
Cc: Yuval.Mintz, Ariel.Elior, everest-linux-l2, Ram.Amrani, netdev,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 10 Oct 2016 13:59:16 +0200
> The definition of qed_get_rdma_ops() is not a prototype unless
> we add 'void' here, as indicated by this W=1 warning:
>
> drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ‘qed_get_rdma_ops’:
> drivers/net/ethernet/qlogic/qed/qed_roce.c:2950:28: error: old-style function definition [-Werror=old-style-definition]
>
> Fixes: abd49676c707 ("qed: Add RoCE ll2 & GSI support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Again, Qlogic folks, please properly review patches posted against your
driver.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] qed: fix old-style function definition
2016-10-13 13:55 ` David Miller
@ 2016-10-13 14:15 ` Mintz, Yuval
2016-10-13 14:53 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Mintz, Yuval @ 2016-10-13 14:15 UTC (permalink / raw)
To: David Miller, arnd@arndb.de
Cc: Yuval.Mintz@qlogic.com, Ariel.Elior@qlogic.com,
everest-linux-l2@qlogic.com, Amrani, Ram, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
> > The definition of qed_get_rdma_ops() is not a prototype unless we add
> > 'void' here, as indicated by this W=1 warning:
> >
> > drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ‘qed_get_rdma_ops’:
> > drivers/net/ethernet/qlogic/qed/qed_roce.c:2950:28: error: old-style
> > function definition [-Werror=old-style-definition]
> >
> > Fixes: abd49676c707 ("qed: Add RoCE ll2 & GSI support")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Again, Qlogic folks, please properly review patches posted against your driver.
>
> Thanks.
Sorry, managed to miss this one.
Acked-by: Yuval Mintz <Yuval.Mintz@caviumnetworks.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] qed: fix old-style function definition
2016-10-13 14:15 ` Mintz, Yuval
@ 2016-10-13 14:53 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2016-10-13 14:53 UTC (permalink / raw)
To: Yuval.Mintz
Cc: arnd, Yuval.Mintz, Ariel.Elior, everest-linux-l2, Ram.Amrani,
netdev, linux-kernel
From: "Mintz, Yuval" <Yuval.Mintz@cavium.com>
Date: Thu, 13 Oct 2016 14:15:51 +0000
>> > The definition of qed_get_rdma_ops() is not a prototype unless we add
>> > 'void' here, as indicated by this W=1 warning:
>> >
>> > drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ‘qed_get_rdma_ops’:
>> > drivers/net/ethernet/qlogic/qed/qed_roce.c:2950:28: error: old-style
>> > function definition [-Werror=old-style-definition]
>> >
>> > Fixes: abd49676c707 ("qed: Add RoCE ll2 & GSI support")
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Again, Qlogic folks, please properly review patches posted against your driver.
>>
>> Thanks.
>
> Sorry, managed to miss this one.
> Acked-by: Yuval Mintz <Yuval.Mintz@caviumnetworks.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-13 15:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-10 11:59 [PATCH] qed: fix old-style function definition Arnd Bergmann
2016-10-13 13:55 ` David Miller
2016-10-13 14:15 ` Mintz, Yuval
2016-10-13 14:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox