* [PATCH trivial] net: add bbr to config DEFAULT_TCP_CONG
@ 2016-10-14 7:33 Markus Trippelsdorf
2016-10-14 7:43 ` Eric Dumazet
0 siblings, 1 reply; 4+ messages in thread
From: Markus Trippelsdorf @ 2016-10-14 7:33 UTC (permalink / raw)
To: Neal Cardwell; +Cc: netdev
While playing with BBR I noticed that it was missing in the list of
possible config DEFAULT_TCP_CONG choices. Fixed thusly.
Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index 300b06888fdf..b54b3ca939db 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -715,6 +715,7 @@ config DEFAULT_TCP_CONG
default "reno" if DEFAULT_RENO
default "dctcp" if DEFAULT_DCTCP
default "cdg" if DEFAULT_CDG
+ default "bbr" if DEFAULT_BBR
default "cubic"
config TCP_MD5SIG
--
Markus
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH trivial] net: add bbr to config DEFAULT_TCP_CONG
2016-10-14 7:33 [PATCH trivial] net: add bbr to config DEFAULT_TCP_CONG Markus Trippelsdorf
@ 2016-10-14 7:43 ` Eric Dumazet
2016-10-14 8:07 ` Markus Trippelsdorf
0 siblings, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2016-10-14 7:43 UTC (permalink / raw)
To: Markus Trippelsdorf; +Cc: Neal Cardwell, netdev
On Fri, 2016-10-14 at 09:33 +0200, Markus Trippelsdorf wrote:
> While playing with BBR I noticed that it was missing in the list of
> possible config DEFAULT_TCP_CONG choices. Fixed thusly.
>
> Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
>
> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
> index 300b06888fdf..b54b3ca939db 100644
> --- a/net/ipv4/Kconfig
> +++ b/net/ipv4/Kconfig
> @@ -715,6 +715,7 @@ config DEFAULT_TCP_CONG
> default "reno" if DEFAULT_RENO
> default "dctcp" if DEFAULT_DCTCP
> default "cdg" if DEFAULT_CDG
> + default "bbr" if DEFAULT_BBR
> default "cubic"
Not sure if we want this at this moment.
BBR needs FQ packet scheduler, and this is not exactly trivial to
achieve.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH trivial] net: add bbr to config DEFAULT_TCP_CONG
2016-10-14 7:43 ` Eric Dumazet
@ 2016-10-14 8:07 ` Markus Trippelsdorf
2016-10-14 15:17 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Markus Trippelsdorf @ 2016-10-14 8:07 UTC (permalink / raw)
To: Eric Dumazet; +Cc: Neal Cardwell, netdev
On 2016.10.14 at 09:43 +0200, Eric Dumazet wrote:
> On Fri, 2016-10-14 at 09:33 +0200, Markus Trippelsdorf wrote:
> > While playing with BBR I noticed that it was missing in the list of
> > possible config DEFAULT_TCP_CONG choices. Fixed thusly.
> >
> > Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
> >
> > diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
> > index 300b06888fdf..b54b3ca939db 100644
> > --- a/net/ipv4/Kconfig
> > +++ b/net/ipv4/Kconfig
> > @@ -715,6 +715,7 @@ config DEFAULT_TCP_CONG
> > default "reno" if DEFAULT_RENO
> > default "dctcp" if DEFAULT_DCTCP
> > default "cdg" if DEFAULT_CDG
> > + default "bbr" if DEFAULT_BBR
> > default "cubic"
>
> Not sure if we want this at this moment.
>
> BBR needs FQ packet scheduler, and this is not exactly trivial to
> achieve.
For a start, it could be automatically selected:
diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index 300b06888fdf..845d8d3e9e27 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -642,6 +642,8 @@ config TCP_CONG_CDG
config TCP_CONG_BBR
tristate "BBR TCP"
+ select NET_SCHED
+ select NET_SCH_FQ
default n
---help---
--
Markus
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH trivial] net: add bbr to config DEFAULT_TCP_CONG
2016-10-14 8:07 ` Markus Trippelsdorf
@ 2016-10-14 15:17 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2016-10-14 15:17 UTC (permalink / raw)
To: markus; +Cc: eric.dumazet, ncardwell, netdev
From: Markus Trippelsdorf <markus@trippelsdorf.de>
Date: Fri, 14 Oct 2016 10:07:16 +0200
> On 2016.10.14 at 09:43 +0200, Eric Dumazet wrote:
>> On Fri, 2016-10-14 at 09:33 +0200, Markus Trippelsdorf wrote:
>> > While playing with BBR I noticed that it was missing in the list of
>> > possible config DEFAULT_TCP_CONG choices. Fixed thusly.
>> >
>> > Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
>> >
>> > diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
>> > index 300b06888fdf..b54b3ca939db 100644
>> > --- a/net/ipv4/Kconfig
>> > +++ b/net/ipv4/Kconfig
>> > @@ -715,6 +715,7 @@ config DEFAULT_TCP_CONG
>> > default "reno" if DEFAULT_RENO
>> > default "dctcp" if DEFAULT_DCTCP
>> > default "cdg" if DEFAULT_CDG
>> > + default "bbr" if DEFAULT_BBR
>> > default "cubic"
>>
>> Not sure if we want this at this moment.
>>
>> BBR needs FQ packet scheduler, and this is not exactly trivial to
>> achieve.
>
> For a start, it could be automatically selected:
Right but FQ has to be properly enabled and configured as well.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-14 15:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-14 7:33 [PATCH trivial] net: add bbr to config DEFAULT_TCP_CONG Markus Trippelsdorf
2016-10-14 7:43 ` Eric Dumazet
2016-10-14 8:07 ` Markus Trippelsdorf
2016-10-14 15:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox