* [PATCH net-next] nfnetlink_log: Use GFP_NOWARN for skb allocation
@ 2016-10-07 21:02 Calvin Owens
2016-10-21 10:38 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Calvin Owens @ 2016-10-07 21:02 UTC (permalink / raw)
To: Pablo Neira Ayuso, Patrick McHardy, Jozsef Kadlecsik,
David S. Miller
Cc: netfilter-devel, coreteam, netdev, linux-kernel, kernel-team,
Calvin Owens
Since the code explicilty falls back to a smaller allocation when the
large one fails, we shouldn't complain when that happens.
Signed-off-by: Calvin Owens <calvinowens@fb.com>
---
net/netfilter/nfnetlink_log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c
index eb086a1..7435505 100644
--- a/net/netfilter/nfnetlink_log.c
+++ b/net/netfilter/nfnetlink_log.c
@@ -330,7 +330,7 @@ nfulnl_alloc_skb(struct net *net, u32 peer_portid, unsigned int inst_size,
* message. WARNING: has to be <= 128k due to slab restrictions */
n = max(inst_size, pkt_size);
- skb = alloc_skb(n, GFP_ATOMIC);
+ skb = alloc_skb(n, GFP_ATOMIC | __GFP_NOWARN);
if (!skb) {
if (n > pkt_size) {
/* try to allocate only as much as we need for current
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] nfnetlink_log: Use GFP_NOWARN for skb allocation
2016-10-07 21:02 [PATCH net-next] nfnetlink_log: Use GFP_NOWARN for skb allocation Calvin Owens
@ 2016-10-21 10:38 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2016-10-21 10:38 UTC (permalink / raw)
To: Calvin Owens
Cc: Patrick McHardy, Jozsef Kadlecsik, David S. Miller,
netfilter-devel, coreteam, netdev, linux-kernel, kernel-team
On Fri, Oct 07, 2016 at 02:02:16PM -0700, Calvin Owens wrote:
> Since the code explicilty falls back to a smaller allocation when the
> large one fails, we shouldn't complain when that happens.
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-21 10:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-07 21:02 [PATCH net-next] nfnetlink_log: Use GFP_NOWARN for skb allocation Calvin Owens
2016-10-21 10:38 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox